Skip to content

Share Voxtype status across bar surfaces - #8734

Open
lamchun1110 wants to merge 1 commit into
omacom:quattrofrom
lamchun1110:fix/shared-dictation-status-service
Open

lamchun1110 wants to merge 1 commit into
omacom:quattrofrom
lamchun1110:fix/shared-dictation-status-service

Conversation

@lamchun1110

Copy link
Copy Markdown

Fixes #8674

Summary

  • add a first-party omarchy.dictation service that owns the single long-running omarchy-voxtype-status process
  • bind every Dictation indicator instance to that shared service instead of starting one follower per monitor
  • keep the existing recording/transcribing state and click behavior intact
  • add regression coverage for single process ownership and shared-state propagation

Why

Dictation.qml is instantiated once per bar surface. Owning the follower there starts one voxtype status --follow process per monitor and can accumulate more as surfaces are rebuilt. The shell already has a service loader specifically for state shared across UI instances, so the follower now lives there once per shell session.

Tests

  • bash test/shell.d/plugins-test.sh
  • bash test/shell.d/indicator-contract-test.sh (single-owner assertion passes; live QML portion skipped because this host has no Wayland compositor)
  • bash test/shell.d/manifest-entrypoints-test.sh (skipped because this host has no Wayland compositor)
  • bash -n bin/omarchy-voxtype-status test/shell.d/indicator-contract-test.sh
  • jq empty shell/plugins/services/dictation/manifest.json
  • git diff --check

The broader config test was not runnable on this macOS host because lua is unavailable.

@paulogeyer

Copy link
Copy Markdown
Contributor

The code this PR changes is no longer on quattro: c248890 (#14552) removed both omarchy-voxtype-status and the bar Dictation.qml indicator whose status it shared across surfaces. Checked against current quattro. I think this one can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dictation bar indicator leaks duplicated voxtype status --follow processes

3 participants