Repository navigation
Share Voxtype status across bar surfaces - #8734
Open
lamchun1110 wants to merge 1 commit into
Open
lamchun1110 wants to merge 1 commit into
lamchun1110 wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8674
Summary
omarchy.dictationservice that owns the single long-runningomarchy-voxtype-statusprocessWhy
Dictation.qmlis instantiated once per bar surface. Owning the follower there starts onevoxtype status --followprocess per monitor and can accumulate more as surfaces are rebuilt. The shell already has a service loader specifically for state shared across UI instances, so the follower now lives there once per shell session.Tests
bash test/shell.d/plugins-test.shbash test/shell.d/indicator-contract-test.sh(single-owner assertion passes; live QML portion skipped because this host has no Wayland compositor)bash test/shell.d/manifest-entrypoints-test.sh(skipped because this host has no Wayland compositor)bash -n bin/omarchy-voxtype-status test/shell.d/indicator-contract-test.shjq empty shell/plugins/services/dictation/manifest.jsongit diff --checkThe broader config test was not runnable on this macOS host because
luais unavailable.