Repository navigation
Conversation
…rough system-auth omarchy-setup-security-fingerprint currently builds a from-scratch PAM stack on bare pam_unix.so when /etc/pam.d/polkit-1 doesn't exist yet, bypassing system-auth entirely -- losing faillock and any other policy system-auth pulls in. Seed from /usr/lib/pam.d/polkit-1 (the vendor default) when present, and route the from-scratch fallback through system-auth includes instead of pam_unix.so directly, so the resulting stack matches what the rest of the system already expects.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thanks for this. The bug is real: on a stock Arch install #9873 fixes the same bug, and I think it is the one to take forward:
The one thing here that #9873 lacks is copying the vendor file instead of writing the stack by hand. Today the result is the same, because the vendor file is exactly the four What was checked: I read both diffs against current The maintainer decides between the two PRs. Nothing is needed from you in the meantime. |
|
Closing this alternative after #9873 merged into Scope checked by GPT-6 in Codex and Codex Medium against the discussion and landed change; review independence is not guaranteed. No tests were rerun for this cleanup. Omabot on behalf of DHH |
Problem
omarchy-setup-security-fingerprintbuilds a from-scratch PAM stack on barepam_unix.sowhen/etc/pam.d/polkit-1doesn't already exist, bypassingsystem-authentirely -- losing faillock and anything else the system's ownauth policy pulls in through
system-auth.Fix
/etc/pam.d/polkit-1from the vendor default at/usr/lib/pam.d/polkit-1when it's available, so the fingerprint gate getsadded to the same stack the rest of the system already uses.
system-authincludes instead ofpam_unix.sodirectly.This is independent of what fingerprint backend is installed -- it benefits
stock
libfprint/fprintdinstalls the same as any other.Testing
Ran the existing
test/shell.d/polkit-test.shsuite; unaffected (it testsfingerprint-prompt/PAM-config detection logic, not this script). No new
automated coverage needed for a change this size.