Repository navigation
Conversation
The ELAN match-on-chip v2 reader (04f3:0c4c) has an elanmoc2 driver stock libfprint does not ship, so setup left those machines with fprintd reporting no devices. Select the libfprint provider package by exact USB ID before installing, keep any already-installed replacement provider on re-runs, and drop it again on removal.
There was a problem hiding this comment.
Pull request overview
Adds hardware-specific libfprint provider selection for ELAN 04f3:0c4c fingerprint readers.
Changes:
- Selects and installs
libfprint-elanmoc2-gitfor the exact USB ID. - Handles conflicting provider removal and teardown.
- Adds focused provider-selection tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-hw-fingerprint-lib-package |
Selects the appropriate provider. |
bin/omarchy-setup-security-fingerprint |
Installs the selected provider safely. |
bin/omarchy-remove-security-fingerprint |
Removes the ELAN provider during teardown. |
test/shell.d/fingerprint-lib-package-test.sh |
Tests exact matching and provider persistence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Reviewed at 7e3f919 by Claude Opus 5.5. The second opinion (Codex Medium) did not run: the reviewer answered a ping but refused the review because its daily budget was spent, so this is one model's reading. The problem is real on current This branch no longer fits One defect in the diff as it stands ( Worth weighing whichever route is chosen: Tested: on a credential-free worker built from the Omarchy ISO, against the PR head, the new Waiting on: the maintainer, to decide whether 04f3:0c4c support goes into the omarchy-pkgs |
|
One more reader for this family: ELAN It behaves the same as
The {.vid = ELANMOC2_VEND_ID, .pid = 0x0c00, .driver_data = ELANMOC2_ALL_DEV},
{.vid = ELANMOC2_VEND_ID, .pid = 0x0c4c, .driver_data = ELANMOC2_ALL_DEV},So whichever route is chosen (elanmoc2 in the omarchy-pkgs pin, or a per-reader provider), The detection side is in #17672. |
|
Following up on my earlier comment: I tested the omarchy-pkgs route on my It carries libfprint MR !330 as a patch in the On an HP Pavilion Aero 13-be0xxx with The patch leaves out the MR's changes to libfprint core (they fail libfprint's own I haven't tested |
|
Looked at this again at 7e3f919 (unchanged since the last review), because a competing fix has appeared: omacom/omarchy-pkgs#2170 by @moses-y. It adds the The project's default is that the older fix wins. #2170 is preferred here only because of defects in this branch that #2170 doesn't have:
Codex also found a smaller problem in the new test. The "no matching USB devices" case only runs Neither model found anything in this branch worth carrying over into #2170. Some limits on what's known about #2170: it was tested on hardware only with a Waiting on: the maintainer to choose between this PR and omacom/omarchy-pkgs#2170. Nothing is needed from you before then. Thanks for tracking this reader down in the first place: your PR is what pointed the packaging work at the right driver. |
Summary
Add support for ELAN match-on-chip v2 fingerprint readers with USB ID
04f3:0c4c.These readers identify as
ELAN:ARM-M4, but stocklibfprintlacks the requiredelanmoc2driver. Setup detects the reader, butfprintdreports no usable device.Changes
04f3:0c4cby exact USB ID.libfprint-elanmoc2-git.Packaging
I understand that Omarchy is repackaging the most useful AUR packages itself. Preferably,
libfprint-elanmoc2-gitshould be packaged in the Omarchy repositories rather than installed directly from the AUR. This PR uses the AUR package because it is not currently available in Omarchy repositories.Related Work
libfprint.This PR focuses specifically on making the
04f3:0c4cELAN reader work with the appropriate provider.Testing