Repository navigation
Conversation
Member
|
Automated duplication check: this pull request looks similar to #7307, which covers the same screensaver font scaling. I keep that one open and close this one to consolidate review. If you feel this is the wrong decision, please open the PR again with a note on the difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #9027
The screensaver launchers hardcoded an 18pt font, but the wordmark needs 81 columns. On a 1080p/143-DPI panel, Omarchy's own
omarchy_monitor_scale = "auto"resolves to scale 2, whose 960-column logical viewport fits only 66 columns —ttfxcentre-cropped the art down to "MARCH".Each terminal launch now sizes its font from the target monitor's scale (
18 / scale, clamped to 6–18) via a newomarchy_screensaver_font_sizehelper indefault/bash/fns/screensaver. The wordmark's physical size — and therefore its column budget — stays constant on every display: scale 1 keeps the shipped 18, scale 2 gets 9, and sub-unity scales cap at 18.--font="JetBrainsMono Nerd Font:size=$font", Alacritty--option font.size=$font, and Ghostty/Kitty their existing flags with the computed valueTests:
bash test/shell.d/screensaver-font-size-test.shbash -n bin/omarchy-launch-screensaver default/bash/fns/screensavergit diff --check