Skip to content

Tell agents to check open PRs before writing a fix - #9091

Closed
rdoupe wants to merge 1 commit into
omacom:quattrofrom
rdoupe:docs/check-open-prs-before-fixing
Closed

rdoupe wants to merge 1 commit into
omacom:quattrofrom
rdoupe:docs/check-open-prs-before-fixing

Conversation

@rdoupe

@rdoupe rdoupe commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Problem

AGENTS.md says nothing about looking for existing work before opening a PR — no mention of pull requests, duplicates, or searching. With the backlog where it is, that omission is expensive: one bug draws several independent fixes that all have to be read and compared before any can be merged.

Two clusters found without looking hard:

Lock screen losing password focus after suspend — four open PRs:

PR Approach
#7164 refocus on secure becoming true
#7592 100ms polling Timer while unfocused
#8560 onActiveFocusChanged reclaims focus
#8869 100ms polling Timer + focus: true

Wi-Fi password reveal toggle — two open PRs: #7815 and #8019 add the same toggle.

I am not reporting this from the outside. I hit the bug, diagnosed it, wrote a fix and opened #9089 — the fifth PR on that lock bug — before finding the other four. I have since closed it as a duplicate. This change is the fix for what actually went wrong, which was the process, not the patch.

Change

Adds a Pull Requests section to AGENTS.md: search before writing, search twice because one query does not catch a PR that describes the same area in different words, and when an open PR already covers the change, add to it — confirm the bug, review the approach, contribute a missing test — rather than opening a competing one.

Docs only, no code or test changes. Written as full lines with a fenced bash block, matching the file's own Style section and the Refresh Pattern example.

The open backlog is large enough that one bug draws several independent
fixes. The lock screen losing password focus after suspend had four open
PRs before a fifth was filed; the Wi-Fi password reveal toggle has two.

AGENTS.md said nothing about looking first, so add a Pull Requests section
with the searches to run and what to do when one already covers the change.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019q6kd5nX4D8xS7jy7KJYtP
@rdoupe

rdoupe commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

Closing — wrong file. default/agents/skills/omarchy/contributing.md is titled "Reporting Issues and Submitting PRs" and already has a ## Submitting a PR section, so that is where this belongs. It also ships in the omarchy skill, which is what an agent on a user's machine actually reads before contributing upstream — the duplicate gets written before anyone opens AGENTS.md. Reopening against that file.

@rdoupe rdoupe closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant