Repository navigation
[codex] OM-SEC-05: Remove the unsigned Apple T2 package source - #9461
AFOliveira wants to merge 6 commits into
Conversation
Retire the unauthenticated source, fail closed until all five signed Omarchy replacements exist, reinstall without trusting legacy bytes, and publish completion only after explicit transaction success.
f50792a to
7b66647
Compare
|
Narrowed and force-pushed 7b66647 after local re-review. The shared OM-SEC-04/05 test is gone; this PR now has a T2-only provenance regression and four files total (328 lines vs 495). It also explicitly handles reinstall failure before marker publication. Compared with #8709, this removes the unauthenticated source and fails closed rather than continuing to accept unsigned packages under PackageOptional. Local evidence on current quattro b71dcad: real Pacman SigLevel=Never proof succeeds, repository-origin mutation detected, focused provenance and T2 hardware tests pass, CLI 116/116, shell 225/226 with only the base-identical launch-about failure. Keeping the PR draft: all five signed replacement packages are still a release blocker. |
There was a problem hiding this comment.
🟡 Changes recommended
The migration incorrectly treats secure DatabaseOptional policy as unsafe and removes the repository section.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Retires the unsigned Apple T2 repository and requires authenticated replacements from Omarchy’s repository.
Changes:
- Removes the legacy
arch-mact2source. - Adds signed-policy and package-origin validation.
- Migrates existing installations and adds provenance regressions.
File summaries
| File | Description |
|---|---|
install/hardware/pacman.sh |
Stops restoring the unsigned repository. |
install/hardware/apple/fix-t2.sh |
Gates T2 setup on trusted packages. |
migrations/1788163636.sh |
Disables the legacy source and reinstalls packages securely. |
test/shell.d/t2-package-provenance-test.sh |
Tests policy, provenance, failure, and retry behavior. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| found { print } | ||
| ' "$pacman_conf") | ||
| [[ -n $section ]] || return 0 | ||
| /usr/bin/grep -Eq '^[[:space:]]*SigLevel[[:space:]]*=.*((Package)?(Never|Optional)|TrustAll)([[:space:]]|$)' <<<"$section" || return 0 |
Retire Omarchy's unauthenticated Apple T2 package source and require all five replacements from the signed Omarchy repository before setup or migration can complete (OM-SEC-05).
The migration resolves effective policy through
pacman-conf, including inheritance, includes and directive precedence.DatabaseOptionaland other database-only exceptions do not cause safe package policy to be removed. An unsafe Omarchy-createdarch-mact2section is privately backed up and disabled before the package transaction. An unsafe section wholly inside a custom include remains pending with explicit administrator recovery instructions; it is not silently marked repaired.Affected machines use one fixed, packaged system operation under a machine lock. It rechecks shared state after acquiring the lock, runs without nested sudo prompts, and publishes completion only after a successful reinstall. Unaffected and already repaired machines need no authentication request. Discovery failures remain pending. Both queries and installation use explicit
omarchy/packagetargets, and same-version packages are reinstalled because their existing bytes may come from the retired unsigned source.Fresh setup follows the same policy and repository checks, propagates PCI discovery errors and writes hardware configuration only after authenticated package installation succeeds. The PR remains limited to four files.
Validation on
9fb88358e73e2fce9d6a0a1b67d8ad5707e0f95f, integrated with quattroe848f1df:flockconcurrency, query/discovery failures, retries, completion ordering and repository-bound transactions.This remains a draft. The current stable, rc and edge repository databases contain none of
linux-t2,linux-t2-headers,apple-t2-audio-config,apple-bcm-firmwareort2fanrd. All five signed artifacts, production trust-chain acceptance, package lifecycle and real T2 boot/audio/connectivity/fan behavior remain release gates. Fixture coverage does not establish hardware readiness.Related: #8709 also changes T2 signature policy, but optional package signatures still permit unsigned packages. This PR requires a complete authenticated replacement set. Quattro bootstrap authenticity is handled separately in #9460.