Skip to content

[codex] OM-SEC-06: Keep support data in private workspaces - #9462

Closed
AFOliveira wants to merge 1 commit into
omacom:quattrofrom
AFOliveira:codex/om-sec-06-private-support-data
Closed

AFOliveira wants to merge 1 commit into
omacom:quattrofrom
AFOliveira:codex/om-sec-06-private-support-data

Conversation

@AFOliveira

Copy link
Copy Markdown
Member

Summary

Debug/support output containing machine details and logs was published at predictable shared paths and could be read by another local user.

Finding: OM-SEC-06

Security impact

Another local account can read collected logs, hardware details, identifiers, and other support data left at predictable shared paths.

Remediation

Collection uses unique private workspaces, restrictive umask/modes, fixed privileged readers, bounded selectors, atomic private save behavior, and cleanup on every exit path.

The reviewed implementation applies these concrete controls:

  • Runtime roots are canonical, non-symlink, correctly owned, and private.
  • Each invocation uses a unique mode-0700 workspace and mode-0600 files under umask 077.
  • Predictable shared /tmp artifacts are gone.
  • Cleanup runs for upload, print, save, failure, cancellation, and signals.
  • Deliberate save copies only to a validated final destination.

Validation

A second mapped UID read the baseline debug log; foreign-parent, symlink, concurrency, root-log, upload, save, and signal tests pass.

Detailed regression coverage: support-log-security-test.sh covers foreign ancestors, symlinks, concurrency, root-log reads, dmesg authorization, cleanup, and saved output.

Current status: Fixed. Historical exposed log bytes cannot be made secret again.

All changed shell files on this branch pass bash -n, and git diff --check passes.

Coordination

This is one finding in a coordinated 21-finding disclosure sent to the Omarchy security team. The corresponding Markdown report contains the affected-code analysis and safe reproduction.

This branch is independently reviewable against quattro.

@AFOliveira
AFOliveira marked this pull request as draft September 1, 2026 09:49
@AFOliveira

Copy link
Copy Markdown
Member Author

Closing this duplicate in favor of #8370. I compared the complete PR-local patches against their respective merge bases and they are identical (stable patch ID 37ee2da57006f53168984740f442bb67d2532b39). #8370 predates this disclosure branch and should remain the single review target. OM-SEC-06 remains validated; only the duplicate remediation PR is being withdrawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant