Repository navigation
[codex] OM-SEC-06: Keep support data in private workspaces - #9462
Closed
AFOliveira wants to merge 1 commit into
Closed
AFOliveira wants to merge 1 commit into
AFOliveira wants to merge 1 commit into
Conversation
AFOliveira
marked this pull request as draft
September 1, 2026 09:49
Member
Author
|
Closing this duplicate in favor of #8370. I compared the complete PR-local patches against their respective merge bases and they are identical (stable patch ID |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Debug/support output containing machine details and logs was published at predictable shared paths and could be read by another local user.
Finding: OM-SEC-06
Security impact
Another local account can read collected logs, hardware details, identifiers, and other support data left at predictable shared paths.
Remediation
Collection uses unique private workspaces, restrictive umask/modes, fixed privileged readers, bounded selectors, atomic private save behavior, and cleanup on every exit path.
The reviewed implementation applies these concrete controls:
Validation
A second mapped UID read the baseline debug log; foreign-parent, symlink, concurrency, root-log, upload, save, and signal tests pass.
Detailed regression coverage: support-log-security-test.sh covers foreign ancestors, symlinks, concurrency, root-log reads, dmesg authorization, cleanup, and saved output.
Current status: Fixed. Historical exposed log bytes cannot be made secret again.
All changed shell files on this branch pass
bash -n, andgit diff --checkpasses.Coordination
This is one finding in a coordinated 21-finding disclosure sent to the Omarchy security team. The corresponding Markdown report contains the affected-code analysis and safe reproduction.
This branch is independently reviewable against
quattro.