Repository navigation
[codex] OM-SEC-10: Replace the world-writable installer log - #9465
Draft
AFOliveira wants to merge 10 commits into
Draft
AFOliveira wants to merge 10 commits into
AFOliveira wants to merge 10 commits into
Conversation
AFOliveira
marked this pull request as draft
September 1, 2026 09:49
AFOliveira
force-pushed
the
codex/om-sec-10-private-installer-log
branch
from
September 1, 2026 21:21
96b51f1 to
747ce81
Compare
Member
Author
|
Reworked this draft after the review-wide complexity audit. The branch is now additive to #8169, removes the unrelated Validated at |
…dex/portfolio-9457-20260907
# Conflicts: # bin/omarchy-security-functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the shared writable installer log with a fresh root-owned mode-0600 inode, validates the log and its parent directories, and migrates legacy installer-log state. Support uploads collect through one fixed root reader accepting no caller paths; both fixed log locations are validated before output and identical/prefix copies are deduplicated. Finding: OM-SEC-10.
Desktop collection clears existing sudo authorization, uses one
sudo -Nread phase and revokes on completion/error. The uploader now validates canonical privileged-Bash startup and its shared library before configurable collectors run. Root and nonroot read failures explicitly remove partial output and propagate failure; confirmed absence remains distinct. This also fixes a root-only error hidden by Bash's conditional errexit semantics.Current candidate
78c26135integrates Quattro and #9457 by ordinary full merges, with an identical shared helper. Independent Daybreak final review accepts the corrections. Focused logging/read/metadata/partial-failure/startup fixtures, CLI112, syntax and whitespace checks pass. No live logs were uploaded and no host installer log was changed.#8169 overlaps fresh-inode/log ownership and #8370 overlaps private upload staging. Their overlapping hunks need rebasing or supersession against the final merged implementation; listing them as dependencies does not establish compatible code. Preserve their authors' credit when reconciling those PRs. Fresh ISO installation remains a release integration gate, and the settings-owned upload command requires the coordinated source/package release.