Skip to content

[codex] OM-SEC-10: Replace the world-writable installer log - #9465

Draft
AFOliveira wants to merge 10 commits into
omacom:quattrofrom
AFOliveira:codex/om-sec-10-private-installer-log
Draft

AFOliveira wants to merge 10 commits into
omacom:quattrofrom
AFOliveira:codex/om-sec-10-private-installer-log

Conversation

@AFOliveira

@AFOliveira AFOliveira commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

Replaces the shared writable installer log with a fresh root-owned mode-0600 inode, validates the log and its parent directories, and migrates legacy installer-log state. Support uploads collect through one fixed root reader accepting no caller paths; both fixed log locations are validated before output and identical/prefix copies are deduplicated. Finding: OM-SEC-10.

Desktop collection clears existing sudo authorization, uses one sudo -N read phase and revokes on completion/error. The uploader now validates canonical privileged-Bash startup and its shared library before configurable collectors run. Root and nonroot read failures explicitly remove partial output and propagate failure; confirmed absence remains distinct. This also fixes a root-only error hidden by Bash's conditional errexit semantics.

Current candidate 78c26135 integrates Quattro and #9457 by ordinary full merges, with an identical shared helper. Independent Daybreak final review accepts the corrections. Focused logging/read/metadata/partial-failure/startup fixtures, CLI112, syntax and whitespace checks pass. No live logs were uploaded and no host installer log was changed.

#8169 overlaps fresh-inode/log ownership and #8370 overlaps private upload staging. Their overlapping hunks need rebasing or supersession against the final merged implementation; listing them as dependencies does not establish compatible code. Preserve their authors' credit when reconciling those PRs. Fresh ISO installation remains a release integration gate, and the settings-owned upload command requires the coordinated source/package release.

@AFOliveira
AFOliveira marked this pull request as draft September 1, 2026 09:49
@AFOliveira
AFOliveira force-pushed the codex/om-sec-10-private-installer-log branch from 96b51f1 to 747ce81 Compare September 1, 2026 21:21
@AFOliveira

Copy link
Copy Markdown
Member Author

Reworked this draft after the review-wide complexity audit.

The branch is now additive to #8169, removes the unrelated docs/file-layout.md changes, uses the shared source-only helper from #9457, and reuses #8370's private staging model. I also added exact-head evidence for #8169's stale-descriptor gap and mutation-tested the desktop sudo -N reader locally.

Validated at 747ce813: focused tests pass; CLI is 116/116; shell is 221/222 with only the exact-base launch-about-test.sh animation failure.

@omarchybot omarchybot added the enhancement New feature or request label Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants