Repository navigation
Conversation
A key at a dark lock panel is there to wake it, not to start the password. Lid-close suspend also marks the panel blanked so the same holds after resume, and auto-repeats of that key are ignored until it is released.
Author
|
Closing for now. This patch was never loaded in the reporter's running session ( Will reopen after VM verification, not live-session testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
When the lock screen has blanked the display (idle blank, or after sleep), the first key that wakes it is inserted into the password field. Space is the obvious case — a lone dot before you have typed anything — but every character does it. Unlock then fails, or you backspace first.
Holding that key also auto-repeats into the field once the display is considered awake.
Lid-close suspend often wins the race against the lock's five-second blank timer, so the same first-key-is-password bug happens after resume even when Omarchy never blanked the panel itself.
Root Cause
LockView'sKeys.onPressedalways callswakeRequested()and then lets the event fall through to theTextInput. Nothing records that the panel is dark, so a wake keystroke is indistinguishable from the first character of the password.Fix
displayBlankedinrunBlank()/runWake()and hands it to the view.wakeRequested()clears it, accepts the event, and keeps swallowing auto-repeats until that key is released.omarchy-system-sleep-lockblanks the panel once the session is secure, so the frozen QML state still says "blanked" on the first key after resume.Mouse wake is unchanged. Typing after the display is on is unchanged.
Related: #7805. Adjacent open PRs #9157 (dirty fork) and #9211 (does not mark blanked on suspend, and does not swallow auto-repeats).
How to Verify
Super+Escape), wait for the display to blank (~5s), press Space. The field should stay empty; the next character should be the first password dot.Test Plan
test/shell.d/lock-wake-keystroke-test.shand sleep-lock coverage for the blank IPC./test/clipasseslock-wake-keystroke,sleep-lock,lock-blank-fingerprint)Risk Assessment
Low — only the lock password field and the pre-suspend blank. A key pressed while the panel is lit still types. A failed
lock blankIPC is ignored so suspend is not blocked.