Repository navigation
Follow the theme in the font picker, search bar and footer tooltips - #152
Merged
Merged
Conversation
The font picker and the search bar sat on a fixed warm grey, and the footer's tooltips on Material's own dark grey, whatever the theme. They now use the theme's lighter background, the shade code blocks already sit on, and the theme's text colour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge. SummaryThe font picker, search bar, and footer tooltips now use the active theme's panel shade.
No new actionable issues were found in the changes since the previous review. Reviews (3) · Last reviewed commit: "Hide the Font tooltip while the font pic..." · Reviewed by Greptile |
It sat on the list the button had just opened. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The font picker and the search bar sat on a fixed warm grey (
#22221f, or#fffef2in light mode), and the footer's tooltips on Material's own dark grey, whatever the theme.lighter_background, the panel shade code blocks already sit on, which falls back to the page mixed towards the text for themes that don't set it.Backendexposes it asthemePanelBackground.The four dialogs still use fixed greys; that's for a follow-up.
🤖 Generated with Claude Code