Skip to content

Follow the theme in the font picker, search bar and footer tooltips - #152

Merged
dhh merged 2 commits into
masterfrom
font-picker-theme
Nov 12, 2026
Merged

dhh merged 2 commits into
masterfrom
font-picker-theme

Conversation

@dhh

@dhh dhh commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

The font picker and the search bar sat on a fixed warm grey (#22221f, or #fffef2 in light mode), and the footer's tooltips on Material's own dark grey, whatever the theme.

  • They now use the theme's lighter_background, the panel shade code blocks already sit on, which falls back to the page mixed towards the text for themes that don't set it. Backend exposes it as themePanelBackground.
  • The footer buttons draw their own tooltip in that shade with the theme's text colour, since Material's tooltip ignores the palette. The Font button's tooltip is hidden while the picker is open, since it covered the list.

The four dialogs still use fixed greys; that's for a follow-up.

Before After
Before After

🤖 Generated with Claude Code

The font picker and the search bar sat on a fixed warm grey, and the
footer's tooltips on Material's own dark grey, whatever the theme. They
now use the theme's lighter background, the shade code blocks already
sit on, and the theme's text colour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The font picker, search bar, and footer tooltips now use the active theme's panel shade.

  • The search bar and font picker now share the theme’s panel shade.
  • Footer tooltips use the theme’s colors and stay clear of the open font list.

No new actionable issues were found in the changes since the previous review.

Reviews (3) · Last reviewed commit: "Hide the Font tooltip while the font pic..." · Reviewed by Greptile

It sat on the list the button had just opened.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dhh
dhh merged commit be03038 into master Nov 12, 2026
2 checks passed
@dhh
dhh deleted the font-picker-theme branch November 12, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant