Repository navigation
Pick dialog buttons with a bare letter - #154
Merged
Merged
Conversation
The prompt has nothing to type into, so C, D and S are enough, as in omacom/plain#10; Alt with the letter still works and Escape still cancels. The external-change prompt keeps no letter keys: it comes up on its own while the writer types, and Reload throws their changes away. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QKeySequence reads "İ" as Qt::Key_unknown, so "&İptal" bound no key at all, with or without Alt. P is free among the Turkish keys. The catalog check now refuses an access key Qt cannot bind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex <noreply@openai.com>
[Medium impact] The PR appears safe to merge. SummaryThe PR lets users choose unsaved-changes buttons with their translated letter keys, with or without Alt.
Reviews (2) · Last reviewed commit: "Leave no recovery draft behind when the ..." · Reviewed by Greptile |
unsavedChangesDialogTakesTheLetterFromTheEditor types "draft" into the real editor, and Backend keeps that as a crash-recovery draft in the test-mode data folder, which the next run's editor restores. The test only clears it by choosing Discard at the end, so a run that failed before then, as it does on the old dialog, left "draft" behind and made every later run start with it and fail, change or no change. It now discards the draft however it ends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unsaved-changes prompt needed Alt+C, Alt+D or Alt+S to pick a button. Alt is the convention for dialogs with a text field, where a bare letter would type, but this prompt has nothing to type into, so a bare C, D or S is enough, as omacom/plain#10 made it in Plain. Alt with the letter still works and Escape still cancels. The keys follow the translation's access keys, as before.
The letter reaches the prompt, not the text behind it: the prompt takes focus when it opens, and it only ever opens because the writer closed the window or chose a file to open, so the next key they press is meant for it.
The external-change prompt is left without letter keys. It has no access keys to extend, it comes up on its own while the writer is typing, and Reload throws their changes away, so the next letter typed must never pick a button there, and a test now holds it to that. The shortcuts overlay is left alone too: its single Close button has no access key, and Enter and Escape already close it.
Turkish Cancel ("&İptal") bound no key at all, with or without Alt, because Qt reads İ as an unknown key. It is "İ&ptal" now, and the catalog check refuses an access key Qt cannot bind.
🤖 Generated by Opus 5.5 in Claude Code. Reviewed by Codex XHigh.