Skip to content

Update CI permissions and improve pull request handling#90

Merged
omatheusmesmo merged 9 commits into
mainfrom
develop
Mar 1, 2026
Merged

Update CI permissions and improve pull request handling#90
omatheusmesmo merged 9 commits into
mainfrom
develop

Conversation

@omatheusmesmo
Copy link
Copy Markdown
Owner

This pull request introduces several improvements and refactorings across the frontend and backend documentation, focusing on user experience enhancements, code cleanup, and the addition of new dialog components for managing list items. The most notable changes are the implementation of dialog-based item management, removal of unnecessary logging for cleaner code, and updates to the workflow configuration for better CI/CD security.

Frontend Feature Additions

  • Added ListItemDialogComponent for adding and editing items in a list, including its template and styles (list-item-dialog.component.ts, list-item-dialog.component.html, list-item-dialog.component.scss). The dialogs are now used in ListDetailsComponent for both add and edit actions, improving user interaction and code modularity. [1] [2] [3] [4]
  • Updated ItemsManagementComponent to use a dialog for adding items, replacing placeholder code with a full implementation for better UX.

Codebase Cleanup and Error Handling

  • Removed console logging and improved error handling in UnitsManagementComponent, ItemsManagementComponent, ListDetailsComponent, and auth.interceptor.ts, resulting in cleaner production code and more consistent user feedback via snack bars. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Workflow and Documentation Improvements

  • Changed GitHub workflow triggers from pull_request to pull_request_target for improved security and correct event handling, and updated conditional logic to match the new event type. [1] [2] [3]
  • Enhanced the README.md with clearer environment setup instructions, Docker usage, and manual run steps, making onboarding easier for new developers.

Other Refactorings

  • Minor RxJS and import cleanups in ListDetailsComponent for improved code clarity. [1] [2]

These changes collectively improve the maintainability, security, and user experience of the application.

@omatheusmesmo omatheusmesmo merged commit a98a371 into main Mar 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants