Update CI permissions and improve pull request handling#90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings across the frontend and backend documentation, focusing on user experience enhancements, code cleanup, and the addition of new dialog components for managing list items. The most notable changes are the implementation of dialog-based item management, removal of unnecessary logging for cleaner code, and updates to the workflow configuration for better CI/CD security.
Frontend Feature Additions
ListItemDialogComponentfor adding and editing items in a list, including its template and styles (list-item-dialog.component.ts,list-item-dialog.component.html,list-item-dialog.component.scss). The dialogs are now used inListDetailsComponentfor both add and edit actions, improving user interaction and code modularity. [1] [2] [3] [4]ItemsManagementComponentto use a dialog for adding items, replacing placeholder code with a full implementation for better UX.Codebase Cleanup and Error Handling
UnitsManagementComponent,ItemsManagementComponent,ListDetailsComponent, andauth.interceptor.ts, resulting in cleaner production code and more consistent user feedback via snack bars. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Workflow and Documentation Improvements
pull_requesttopull_request_targetfor improved security and correct event handling, and updated conditional logic to match the new event type. [1] [2] [3]README.mdwith clearer environment setup instructions, Docker usage, and manual run steps, making onboarding easier for new developers.Other Refactorings
ListDetailsComponentfor improved code clarity. [1] [2]These changes collectively improve the maintainability, security, and user experience of the application.