Class cast exception when parsing metadata#95
Conversation
…e conversion properly. * Use `Number` type to handle both `Integer` and `Double`. * Convert `Number` to `Double` using `Number.doubleValue()`. Add test cases in `ZarrReaderTest.java` to verify the fix for `parseOmeroMetadata`. * Add test cases to cover both `Integer` and `Double` values in the metadata.
…ferent types of numeric values correctly * Check the type of the value before casting it to `Double` * Convert `Integer` values to `Double` before further processing
|
Cool! If that fixes the error, could you include me as a co-author of the commits from my fork? Or did you copy the commits altogether? |
|
Looks like the tests are failing to build due to @jo-mueller, you can certainly be added to the list of contributors if this change gets included. We have a Contributor License Agreement for the project, would you be able to sign and return the form following the instructions on https://ome-contributing.readthedocs.io/en/latest/cla.html |
|
Hi @dgault , thanks for moving this forward. I already signed the OME agreeement for this PR: ome/omero-py#394 |
|
@jo-mueller: 👍 on the signing. A heads up in case you haven't seen https://forum.image.sc/t/bio-formats-support/101109, though, you might want to re-open this under your own account. |
|
Hi @joshmoore, thanks for the heads-up. I could open a PR with the two commits myself, the issue with that would be that I myself will be on parental leave until December starting the coming Friday. I could probably greenlight any changes to the PR from the mobile app but I think t would be better if somehow could see this through with more regular access to their devices :/ |
|
Understood, and enjoy! If this hasn't made it in by the time you're back, feel free to speak up loudly. |
I'll hold you to it at next year's TiM conference latest if I meet you there ;) |
|
Could be closed in favor of #100 ? |
|
@dominikl : I was going to say that merging your PR will close this one, but I'm not sure that's the case since it looks like the cherry-pick information isn't there (original author, etc.) Edit: ah, now I see #100 (comment) |
|
Maybe I shouldn't have split the commit? Shall I revert it? But it needed another little fix too. Don't know what's the best way to handle that. |
5 participants
This PR is a follow up to #94
I have simply taken the 2 commits from the fork by @jo-mueller : https://github.com/jo-mueller/ZarrReader/tree/fix-classcast-exception
Fixes #94