Performance improvement based on pprofile - #375
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR aims to improve runtime performance in PCF request handling (per profiling) by reducing repeated allocations/lookups on hot paths.
Changes:
- Added a cached UDR (Nudr_DR) API client in
util.GetNudrClientto avoid rebuilding clients repeatedly. - Cached
UdrUrion the UE context to avoid repeated NRF discovery calls. - Reduced log verbosity for high-frequency handler/payload logs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| util/pcf_util.go | Adds global caching for the Nudr_DR API client to reduce repeated client construction. |
| producer/smpolicy.go | Lowers some SM policy logs to Debug and caches UE’s UdrUri after discovery. |
| producer/ampolicy.go | Lowers AM policy create handler log to Debug and reuses cached UE UdrUri before doing NRF discovery. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.