Skip to content

improvement logging and create patch release - #285

Merged
gab-arrobo merged 2 commits into
omec-project:mainfrom
gab-arrobo:improve-logging
Aug 4, 2026
Merged

improvement logging and create patch release#285
gab-arrobo merged 2 commits into
omec-project:mainfrom
gab-arrobo:improve-logging

Conversation

@gab-arrobo

Copy link
Copy Markdown
Contributor

No description provided.

@gab-arrobo
gab-arrobo requested review from a team and a lite review from Copilot August 4, 2026 01:25
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Copilot AI previously approved these changes Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The changes are small and low-risk (version bump + clearer error strings + context-variable cleanup), with only minor best-practice nits noted.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR finalizes a patch release by removing the -dev suffix from the project version and improves MongoDB API error logging context while avoiding context package shadowing in WithContext helpers.

Changes:

  • Promote VERSION from 1.8.4-dev to 1.8.4 for the patch release.
  • Improve MongoDB API error messages to include the specific WithContext method and underlying driver operation (e.g., UpdateOne, DeleteOne, InsertMany).
  • Rename WithContext parameters from context to ctx to avoid shadowing the context package and pass the correct context variable into driver calls.
File summaries
File Description
VERSION Updates version string for the patch release.
mongoapi/mongoapi.go Improves error-message clarity and avoids context identifier shadowing in context-aware MongoDB helpers.
Review details

Suppressed comments (3)

mongoapi/mongoapi.go:212

  • Use %w instead of %+v to wrap the underlying MongoDB error so callers can use errors.Is/errors.As while still preserving the message context.
		return fmt.Errorf("RestfulAPIDeleteOneWithContext DeleteOne err: %+v", err)

mongoapi/mongoapi.go:158

  • Use %w instead of %+v to wrap the underlying MongoDB error so callers can use errors.Is/errors.As while still preserving the message context.
		return fmt.Errorf("RestfulAPIPullOneWithContext UpdateOne err: %+v", err)

mongoapi/mongoapi.go:346

  • Use %w instead of %+v to wrap the underlying MongoDB error so callers can use errors.Is/errors.As while still preserving the message context.
		return fmt.Errorf("RestfulAPIPostManyWithContext InsertMany err: %+v", err)
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment thread mongoapi/mongoapi.go Outdated
Copilot AI review requested due to automatic review settings August 4, 2026 04:56
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
Copilot AI dismissed their stale review, a newer Copilot review was requested August 4, 2026 04:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The changes are small, consistent, and improve error propagation without altering functional behavior.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

@gab-arrobo
gab-arrobo merged commit f1278ed into omec-project:main Aug 4, 2026
9 checks passed
@gab-arrobo
gab-arrobo deleted the improve-logging branch August 4, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants