Add new tests - python#79
Conversation
… test_size_receivers that relies on the size of the samples, less error prone
…ly one from its group of samples
… unsupported tests
…so changed ordered access check function
…est_order to accept instances
… uses the passed tests instead of supported tests
Add HDDS to generate_xlsx_report.py
MiguelCompany
left a comment
MiguelCompany
left a comment
There was a problem hiding this comment.
Would be nice if you could rebase so we can better review the changes
| 'apps' : ['-P -t Square --num-iterations 200 --num-instances 4', | ||
| '-S -t Square'], | ||
| 'expected_codes' : [ReturnCode.OK, ReturnCode.OK], | ||
| 'check_function' : tsf.test_unregistering_w_instances, |
There was a problem hiding this comment.
DDS 1.4 Page 101, pdf page 113, WRITER_DATA_LIFECYCLE QoS, Values autodispose_unregistered_instances
Controls whether a DataWriter will automatically dispose instances each time they are unregistered. The setting autodispose_unregistered_instances = TRUE indicates that unregistered instances will also be considered disposed. By default, TRUE.
Therefore the default behavior should check for disposed instances.
| 'check_function' : tsf.test_unregistering_w_instances, | |
| 'check_function' : tsf.test_disposing_w_instances, |
There was a problem hiding this comment.
I think this is true, however the unregister is what most vendors are doing (including cyclone with other vendors). We need to discuss the behavior of the delete + autodispose behavior next week in the DDS PSIG
|
Merging this to master as a squash. If you have feedback feel free to add it as a pull request |
4 participants
This PR runs several new tests with the options that are already in master. Please upload a new executable, otherwise tests will fail or will show "not supported".
I've created the draft release https://github.com/omg-dds/dds-rtps/releases/tag/untagged-4184f9579b03abc94c64 for the new executables