Repository navigation
fix: allow trusted dataset review after a PR merge - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A deployment stops when its PR was merged without
Dataset review (trusted), but the review workflow previously rejected every closed PR. Allow recovery for a PR merged into canonicalmain, binding the review to its original head and the merge commit's first parent. Require exactly two parents with the PR head as the second parent; reject closed unmerged PRs, squash merges, malformed metadata and changed head/base identities.Resolve the merge commit through the canonical PR timeline because REST 2026-03-10 removed
merge_commit_shafrom PR responses. Keep the existing receipt, archive, publication and deployment checks. Document recovery and remind contributors to complete trusted review before merging deployment changes even when the map graph is unchanged.Validation
pnpm verifyDataset review (trusted)must succeed on this PR's exact head before merge. Merging this fix will deploy the latest main snapshot, including #19; an older deployment should not be rerun over a newer successful deployment.