Skip to content

fix: allow trusted dataset review after a PR merge - #20

Merged
omggga merged 1 commit into
mainfrom
fix/review-merged-dataset-pr
Sep 9, 2026
Merged

omggga merged 1 commit into
mainfrom
fix/review-merged-dataset-pr

Conversation

@omggga

@omggga omggga commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Summary

A deployment stops when its PR was merged without Dataset review (trusted), but the review workflow previously rejected every closed PR. Allow recovery for a PR merged into canonical main, binding the review to its original head and the merge commit's first parent. Require exactly two parents with the PR head as the second parent; reject closed unmerged PRs, squash merges, malformed metadata and changed head/base identities.

Resolve the merge commit through the canonical PR timeline because REST 2026-03-10 removed merge_commit_sha from PR responses. Keep the existing receipt, archive, publication and deployment checks. Document recovery and remind contributors to complete trusted review before merging deployment changes even when the map graph is unchanged.

Validation

  • pnpm verify
  • 51 focused workflow/API/deployment-gate tests passed, including merged review through publication and successful check binding, open-to-merged transitions and rejection cases.
  • Read-only live API check resolves merged PR chore: remove obsolete workflows and LFS restoration #19 to its exact head and original base; the unchanged deployment gate's merge-to-PR lookup also succeeds.
  • Independent diff review found no blocking issues.

Dataset review (trusted) must succeed on this PR's exact head before merge. Merging this fix will deploy the latest main snapshot, including #19; an older deployment should not be rerun over a newer successful deployment.

@omggga
omggga merged commit a610159 into main Sep 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant