Repository navigation
feat: add UESP place links and keep marker sizes consistent - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Place-card names now open UESP articles in a new tab while preserving their typography, with an underline on hover or keyboard focus. Use 4,651 locally matched article titles from saved UESP catalogs; unmatched places use a direct URL built from the map namespace and full place name. Base-game regions in TR use Morrowind mappings. Azurian Isles and personal markers remain unlinked.
Keep every marker shape at its normal size when hovered or selected, retaining color highlighting and label backgrounds. Ignore the local wiki generator, maintainer documentation and matching reports while including the runtime link table.
Validation:
pnpm verify(typecheck, lint, unit and Python suites, browser acceptance, functional/responsive/accessibility UI checks, production build). Focused checks also covered all 4,651 encoded article URLs, namespace fallbacks, ambiguous/distant matches and town-versus-mine selection. Screenshot comparisons were not run; visual review is handled by the maintainer.Article names come from the supplied UESP data or the requested URL pattern; live article existence is not checked.