Repository navigation
Connect GamerZ Hub database read load to Appwrite with verified fallback and sync - #38
Conversation
…allbacks Co-authored-by: omharde42 <193398705+omharde42@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 992b48b551
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| userId, | ||
| gameId: 'freefire', |
There was a problem hiding this comment.
For the normal User.id values generated by this schema (36-character UUIDs), syncTeammateDiscovery derives the Appwrite document ID as freefire_${userId}, which is 45 characters. Appwrite custom document IDs are capped at 36 characters, so both the update and create attempts fail and are swallowed by the best-effort sync; with Appwrite configured, this new Free Fire read model will therefore never be populated.
Useful? React with 👍 / 👎.
| userId, | ||
| game: 'STEAM', |
There was a problem hiding this comment.
The game-profile sync derives its Appwrite document ID as ${userId}_${game}. Since production userIds are 36-character UUIDs, the STEAM suffix produces a 42-character ID, exceeding Appwrite's 36-character custom-ID limit. The rejected update/create calls are caught by the sync service, so every Steam sync silently misses the Appwrite read model.
Useful? React with 👍 / 👎.
| return filteredCached.map(candidate => { | ||
| const matchDetails = this.calculateCompatibility(currentUserProfile, candidate); | ||
| return { | ||
| profile: { | ||
| userId: candidate.userId, |
There was a problem hiding this comment.
Once Appwrite has any matching document, this early return skips both the PostgreSQL query and the lazy synchronization loop. rateTeammate updates FreeFireProfile.reputationScore only in PostgreSQL, so a rating submitted after a candidate has been cached leaves that candidate's cached reputation—and therefore its compatibility score and trust reason—stale indefinitely until that candidate updates their profile again.
Useful? React with 👍 / 👎.
Integrates Appwrite Cloud database read models for game registry, public gamer profiles, game profiles, and teammate discovery into the GamerZ Hub Express backend. Includes write-through sync from PostgreSQL/Supabase, resilient fallback logic on miss/error, and unit tests verifying end-to-end operation.
PR created automatically by Jules for task 11988241612304523473 started by @omharde42