Skip to content

Created in Base should be CreatedAt#58

Open
thetkpark wants to merge 1 commit into
omise:masterfrom
thetkpark:fix/created-at
Open

Created in Base should be CreatedAt#58
thetkpark wants to merge 1 commit into
omise:masterfrom
thetkpark:fix/created-at

Conversation

@thetkpark

Copy link
Copy Markdown

According to the documentation, the created field should be created_at. This results in Created field is always be in zero value.

@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Comment thread base.go
ID string `json:"id"`
Live bool `json:"livemode"`
Location *string `json:"location"`
Created time.Time `json:"created"`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thetkpark but then this would cause a similar issue for users of the library below the current latest version 🤔

@gowriter

gowriter commented Feb 6, 2025

Copy link
Copy Markdown

This issue has been solved already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants