MIT-3392-code-coverage add all files for code coverage#506
MIT-3392-code-coverage add all files for code coverage#506himanshu-opn wants to merge 30 commits into
Conversation
… next line after the body
… next line after the body.
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive unit test coverage for various components of the Omise Payment module. The changes include new test files for controllers, models, observers, plugins, helpers, and other components to improve code coverage.
Changes:
- Added extensive unit tests across multiple components (controllers, models, observers, plugins, gateways, helpers, blocks)
- Created stub files for Magento framework classes to support testing
- Fixed a bug in ConfigSectionPaymentPlugin to prevent duplicate constant definition
- Changed Omise CDN URL from production to staging (appears unintentional)
Reviewed changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| view/frontend/layout/checkout_index_index.xml | Changed Omise.js CDN URL from production to staging |
| Test/Unit/Stubs/* | Added stub interfaces and classes for Magento framework dependencies |
| Test/Unit/Setup/UpgradeDataTest.php | Added unit tests for UpgradeData setup class |
| Test/Unit/Service/CreditMemoServiceTest.php | Added unit tests for CreditMemoService |
| Test/Unit/Plugin/* | Added unit tests for various plugin classes |
| Test/Unit/Observer/* | Added unit tests for observer classes including webhook observers |
| Test/Unit/Model/* | Added unit tests for model classes including API models |
| Test/Unit/Helper/* | Added and updated unit tests for helper classes |
| Test/Unit/Gateway/* | Added unit tests for gateway validators, handlers, and HTTP clients |
| Test/Unit/Controller/* | Added unit tests for controller classes |
| Test/Unit/ConfigTest.php | Added additional test methods for Config class |
| Test/Unit/Block/* | Added unit tests for block classes |
| Plugin/ConfigSectionPaymentPlugin.php | Fixed duplicate constant definition issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <head> | ||
| <css src="Omise_Payment::css/styles.css" /> | ||
| <script src="https://cdn.omise.co/omise.js" src_type="url" /> | ||
| <script src="https://cdn.staging-omise.co/omise.js" src_type="url" /> |
There was a problem hiding this comment.
The URL is being changed from production (cdn.omise.co) to staging (cdn.staging-omise.co). This change appears to be unintentional for a code coverage PR and should likely be reverted unless this is specifically intended for a staging/test environment.
There was a problem hiding this comment.
already same url use of staging.
|
Description
MIT-3392-code-coverage code coverage for all files.
More information (if any)
https://opn-ooo.atlassian.net/browse/MIT-3392