Update class-omise-payment-konbini.php#360
Open
bluantinoo wants to merge 1 commit into
Open
Conversation
Add payment link to konbini emails only if order is not paid yet
Contributor
|
@bluantinoo Thank you for submitting your pull request. We have received it and We will review it as soon as possible. We appreciate your contribution to our project. |
Author
|
@aashishgurung thank you for the quick reaction! I would love 2 options for the single email setting: But generally, I think the payment link on emails sent after a successful transaction makes no sense. Furthermore, the link sent in admin emails is broken. |
ajzkk
removed their request for review
August 30, 2023 02:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add payment link to konbini emails only if order is not paid yet
1. Objective
Konbini Payment link is added in every email notification, this is confusing, both for admins that do not know what they are clicking and for customers that receive notification after successful payment.
This section will be used in the release notes.
2. Description of change
check if the order is still unpaid before adding the Konbini payment link in the email with the woocommerce_email_after_order_table action