Draft
Conversation
Contributor
|
Im not sure if trying to fit the config in an QR code is a future proof strategy. If we add more configuration options this might be a dead end. At least we should think about limiting which option will go into the qr code and which not. At least the mqtt and influx configuration would be very usefull. Which setting did you include into the 6KB? |
Contributor
Author
All of the settings we can currently set via the GUI. See here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Issue:
With the new configuration file format introduced in #66, the config files are approximately 6 KB each, while a QR code can only store up to about 3 KB.
To address this, we have two options:
I prefer the gzip/base64 approach since it avoids the need for an additional service to provision the app. What do you think @derpeter