This repository was archived by the owner on Sep 29, 2022. It is now read-only.
Open
Conversation
Was done automatically by the tool in VS. Reference https://docs.microsoft.com/en-us/nuget/consume-packages/migrate-packages-config-to-package-reference
Does however remove support for VS2015
neo-mashiro
approved these changes
Jan 23, 2022
|
when will this PR be merged to master? it has been 3 months. :) |
|
Is this extension dead? A merge before killing it completely would be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @omsharp,
This PR modifies the project to also support Visual Studio 2022. No code changes were needed and unlike other extensions it was also possible to support 2017, 2019 & 2022 with a single version.
I've just done the minimum that I could get it working for 2022, Which was replacing the project's references with two NuGet packages (reference here). I'm not sure it's 100% equivalent but it's working for me. I tried getting it to work without doing this but ran into dependency errors.
It does however mean (I believe but not 100% sure) that it will no longer work in VS 2015. For my own extension I've now dropped support for 2015 too, but if this is a dealbreaker for you then maybe we can look into it.
For me it's tested & working in VS 2022 (17.0 & 17.1) and 2019.
I've separated the process into small commits but you can squash or edit as you wish.
Thanks for this great extension.