Исправление группировки по полю в Criteria через Projection::group#225
Open
AlexeyDsov wants to merge 1 commit intoonPHP:masterfrom
Open
Исправление группировки по полю в Criteria через Projection::group#225AlexeyDsov wants to merge 1 commit intoonPHP:masterfrom
AlexeyDsov wants to merge 1 commit intoonPHP:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Фикс того что было описано в #54. Внезапно решил ещё раз все посмотреть и подебажить и пришел вот к такому испарвлению. Считаю его кривоватым и не уверен что оно на сто процентов корректное но тесты вроде б не ломаются, хотя SQL в них не так что б хорошо покрыт.
Само исправление в QuerySkeleton, остальное это тест из #54.