Skip to content

Use updated linux runner path and fallback to legacy path#63

Open
cjsimon wants to merge 2 commits into
onatcipli:masterfrom
cjsimon:flutter-3.27.0-support
Open

Use updated linux runner path and fallback to legacy path#63
cjsimon wants to merge 2 commits into
onatcipli:masterfrom
cjsimon:flutter-3.27.0-support

Conversation

@cjsimon
Copy link
Copy Markdown

@cjsimon cjsimon commented Jun 28, 2025

Addresses #62. Untested

Try to use the updated linux runner path introduced in flutter 3.27.0, else fallback to the original

I thought about refactoring using a private helper function, getContentLineByLine, but I wanted to preserve updating the filePath when using the legacyFilePath is successful

@cjsimon
Copy link
Copy Markdown
Author

cjsimon commented Jun 28, 2025

It seems that while there is a new CMakeLists.txt file in the new runner/ directory, the one in the top-level is still present, so the legacyLinuxCMakeListsPath path can be removed.

This might be slightly more complicated than I anticipated. I don't see a kFlutterWindowTitle in the new my_application.cc variant, but an APPLICATION_ID in the top-level CMakeLists.txt file, which I assume could serve as a new linux bundle id:

# The name of the executable created for the application. Change this to change
# the on-disk name of your application.
set(BINARY_NAME "Test")
# The unique GTK application identifier for this application. See:
# https://wiki.gnome.org/HowDoI/ChooseApplicationID
set(APPLICATION_ID "com.example.myapp")

@cjsimon cjsimon force-pushed the flutter-3.27.0-support branch from c0a0aca to ef7a3f2 Compare June 28, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant