Fix unintended Windows key switching - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
1and2map to keyboard VK codes instead of mouse button codesMOD_NOREPEATto prevent held shortcuts from retriggeringCtrl+Win+1,Ctrl+Alt+2, andShift+ARoot cause
.NET Enum.TryParseaccepts numeric strings as raw enum values. The old parser therefore interpreted1asVK_LBUTTONand2asVK_RBUTTON, rather than keyboardVK_1andVK_2. A mode-switch modifier could also remain logically held on the Windows Host because its physical key-up was blocked after entering remote mode. Together, holding Win and clicking could match the malformed return-to-Host hotkey and switch routing unexpectedly.Validation