SQL Alchemy 2.0 upgrade #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #91.
Test suite is borked again; presumably the savepoint logic that I so painstakingly worked out for 1.4 just doesn't work for 2.0.
Through trial and error, I discovered that: * Monkeypatching commit is no longer necessary (and in fact breaks things) * `being_nested()` must be called on the connection * Multiple sessions appear to be safer than passing a single session around
This module was a bit trickier; I was unfortunately unable to find a good way to nest SAVEPOINTs at three levels (e.g. could NOT get package -> module -> function nesting to properly incrementally roll back no matter what I tried), so now all deck tests share the same cards but rebuild their module-based stuff on a per-function basis.
Filtration test wasn't working; probably something to do with the database configuration, and I just don't really care to debug this one because it's a non-issue in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91. And what a pain in the butt implementing this was.
A lot of the find/replace code is minor AI slop; might want to go through and replace the generic
stmtusage with something a little closer to my actual style, but for getting things up and running without needing to spend six hours or whatever of my own time doing incredibly boring find-and-replace, I'll take it.