Skip to content

Clear stale QAM tab descriptor on reinjection - #518

Merged
onehoon merged 2 commits into
mainfrom
refactor/qam-native-descriptor-hotfix
Sep 12, 2026
Merged

onehoon merged 2 commits into
mainfrom
refactor/qam-native-descriptor-hotfix

Conversation

@onehoon

@onehoon onehoon commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix the stale global QAM tab descriptor identified in PR Recover Steam native QAM control interaction #515 follow-up validation.
  • Clear state.addonTabDescriptor at the start of a new install() generation so a script upgrade cannot reuse a descriptor that closes over old React/native components.
  • Clear the descriptor during uninstall() and teardown state reset.
  • Add a contract test covering install-generation reset and both uninstall cleanup paths.

Scope

Validation

  • node --check src/SteamInputAddonforClaw.QamHost/Frontend/qam.js — passed.
  • dotnet build SteamInputAddonforClaw.slnx --configuration Debug --no-restore — passed, 0 warnings, 0 errors.
  • dotnet build SteamInputAddonforClaw.slnx --configuration Release --no-restore — passed, 0 warnings, 0 errors.
  • Focused QAM contract tests — passed, 29/29.
  • Full Release test suite — passed, 2,737/2,737, 0 failed, 0 skipped.
  • git diff --check — passed.

Manual validation

  • The physical MSI Claw/current Steam GamepadUI acceptance pass remains required and was not available in this environment. After deployment, verify that reinstall/reinjection produces QAM page state: Page=Device ... and actual ToggleField/SliderField mutation logs without reusing a previous descriptor.

@onehoon
onehoon marked this pull request as ready for review September 12, 2026 11:30
@onehoon
onehoon merged commit c8942dd into main Sep 12, 2026
1 check passed
@onehoon
onehoon deleted the refactor/qam-native-descriptor-hotfix branch September 13, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant