Skip to content

Add front-button mapping diagnostic logging - #519

Merged
onehoon merged 1 commit into
mainfrom
refactor/front-button-mapping-diagnostics
Sep 12, 2026
Merged

onehoon merged 1 commit into
mainfrom
refactor/front-button-mapping-diagnostics

Conversation

@onehoon

@onehoon onehoon commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Log the frozen-default fallback when FrontButtonMapping is missing or not a JSON object.
  • Log all four effective front-button bindings after a valid settings load.
  • Log all four bindings after a successful front-button mapping save.
  • Add focused coverage for fallback, load, and save diagnostics.

Scope

Diagnostic-only change for WING / OEM1 mapping incidents. Existing defaults, validation, dispatch, persistence behavior, lifecycle, and mapping architecture are unchanged. No migration from legacy Oem1Mapping / WingMapping fields.

Validation

  • Front-button mapping/settings and dispatch focused tests: 24/24 passed.
  • Full test suite: 2737/2737 passed.
  • Release build: 0 warnings, 0 errors.
  • git diff --check passed.
  • Hardware validation is not applicable; this PR adds logging only.

@onehoon
onehoon marked this pull request as ready for review September 12, 2026 11:48
@onehoon
onehoon merged commit e6beadd into main Sep 12, 2026
1 of 2 checks passed
@onehoon
onehoon deleted the refactor/front-button-mapping-diagnostics branch September 12, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant