chore(deps): replace ubi-reader fork by official PyPi version.#504
Merged
chore(deps): replace ubi-reader fork by official PyPi version.#504
Conversation
We cannot use git hosted dependencies if we want to publish unblob to PyPi. We therefore moved from our fork of ubi-reader to the official package of ubi-reader. Our fork was synced with upstream except for one UI change we did to get rid of superfluous directories created by ubireader_extract_images. Since the maintainer of ubi-reader does not want to include it upstream, we moved that logic into the UBIExtractor class. See onekey-sec/ubi_reader#67 for more details.
qkaiser
force-pushed
the
345-bump-ubireader
branch
from
b1da7c9 to
21c51b8
Compare
…encies with poetry.
qkaiser
force-pushed
the
345-bump-ubireader
branch
from
449c251 to
3ead9da
Compare
kissgyorgy
reviewed
Feb 6, 2023
kissgyorgy
approved these changes
Feb 8, 2023
vlaci
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot use git hosted dependencies if we want to publish unblob to PyPi. We therefore moved from our fork of ubi-reader to the official package of ubi-reader.
Our fork was synced with upstream except for one UI change we did to get rid of superfluous directories created by ubireader_extract_images. Since the maintainer of ubi-reader does not want to include it upstream, we moved that logic into the UBIExtractor class.
See onekey-sec/ubi_reader#67 for more details.