Hacky fix to a bug caused by newer versions of the ruby openssl extenension#9
Open
bytecaster wants to merge 1 commit into
Open
Hacky fix to a bug caused by newer versions of the ruby openssl extenension#9bytecaster wants to merge 1 commit into
bytecaster wants to merge 1 commit into
Conversation
…sion using TypedData instead of Data for the OpenSSL Cipher object making extension of said class difficult See onelogin#8
|
This is pretty much exactly what I did (with respect to my comment on #8). The main danger I see with this, is it leaves the gem open to similar issues with future versions of ruby. However, it works with the versions of Ruby I've tried and doesn't suddenly break between 2.1 and 2.2 like the current code does. I'm 👍 on merging, but I have no say here 😄 |
Author
|
Thanks for looking the change over, jtdowney. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hacky fix to a bug caused by newer versions of the ruby openssl extenension using TypedData instead of Data for the OpenSSL Cipher object making extension of said class difficult
See #8