Skip to content

[WIP] Fix client handling of 400 errors in PKCE #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Subterrane merged 2 commits into from
Nov 22, 2025
Merged

[WIP] Fix client handling of 400 errors in PKCE #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8253e38
Initial plan
Copilot Nov 21, 2025
fc3f207
fix: handle 400 errors without rejecting promise
Copilot Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions api/defaultApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,15 @@ export class DefaultApi {
responseTypeName || body?.constructor?.name
);
resolve({ response, body });
} else if (response.statusCode === 400) {
// Handle 400 Bad Request as a successful resolution with error details
// This allows callers to handle client errors gracefully without losing state
// (e.g., in PKCE flows where a 400 shouldn't clear the code verifier)
// Callers can check response.statusCode to detect the error condition
// The error information is available in the response body
resolve({ response, body });
} else {
// For all other errors (401-599), reject the promise
reject(new HttpError(response, body, response.statusCode));
}
}
Expand Down