Fix NoneType decorator crash when tracing system is unavailable - #168
Merged
onenoly1010 merged 2 commits intoJul 30, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix issue with Copilot functionality
Fix NoneType decorator crash when tracing system is unavailable
Jul 29, 2026
onenoly1010
approved these changes
Jul 30, 2026
onenoly1010
force-pushed
the
copilot/fix-copilot-issue
branch
from
July 30, 2026 16:22
3de77ae to
1113c5f
Compare
Co-authored-by: onenoly1010 <193537773+onenoly1010@users.noreply.github.com>
onenoly1010
force-pushed
the
copilot/fix-copilot-issue
branch
from
July 30, 2026 16:35
1113c5f to
d6c8230
Compare
onenoly1010
marked this pull request as ready for review
July 30, 2026 16:37
Contributor
There was a problem hiding this comment.
🟡 Not ready to approve
The new fallbacks return decorators for all tracing helpers, but at least one (trace_consciousness_stream) is used as a context manager (with ...:), which will still fail when tracing is unavailable.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR aims to prevent module-load crashes when tracing_system can’t be imported by ensuring tracing fallbacks are safe to use (especially when used as decorator factories).
Changes:
- Updated tracing fallback callables in
server/main.pyto avoid returningNonewhentracing_systemimport fails. - Intended to make
@trace_fastapi_operation("...")safe even when tracing is unavailable.
File summaries
| File | Description |
|---|---|
server/main.py |
Adjusts tracing fallbacks used when tracing_system import fails. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
tracing_systemfails to import, the fallback lambdas returnedNone, causing aTypeErrorat module load time because@trace_fastapi_operation("health_check")expects the call to return a decorator, notNone.Change
server/main.py— fallback lambdas now return an identity decorator instead ofNone:Applied to all four tracing fallbacks:
trace_consciousness_stream,trace_fastapi_operation,trace_payment_processing,trace_payment_visualization_flow.