Invalid rails locale translation#12
Open
fjsanpedro wants to merge 3 commits into
Open
Conversation
which is an invalid locale code (and rails complains about it) With the funcion removed, you will compare "en-US" (locale code retrieved from OneSky) == "en-US" (Rails App) which is true
…s locale format. Remember, the default_locale is en-US but we want to store the content in files with name like en_US.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a problem with composed locale names (i.e. en-US). With the current code it is necessary to set the default_locale to en_US which is an invalid locale for rails.
I move the locale translation to the file_client which is the component who really need to translate en-US to en_US.
To sum up: