[Compiler] Fix function conversion by SupunS · Pull Request #4517 · onflow/cadence

SupunS · 2026-07-10T20:52:42Z

Description

The function conversion (type clamping) wasn't preserving the dereferenceReceiver flag.

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

github-actions · 2026-07-10T20:52:55Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

github-actions · 2026-07-10T20:58:58Z

Benchstat comparison

Base branch: onflow:master
Base commit: 214f064

Results

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	1.79µs ± 0%	1.58µs ± 0%	~	(p=1.000 n=1+1)
ByteArrayValueToByteSlice-4	82.2ns ± 0%	79.2ns ± 0%	~	(p=1.000 n=1+1)
ByteSliceToByteArrayValue-4	1.40µs ± 0%	1.34µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4	137µs ± 0%	130µs ± 0%	~	(p=1.000 n=1+1)
CompileTime-4	42.6µs ± 0%	40.3µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	411µs ± 0%	402µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	265µs ± 0%	263µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	4.63µs ± 0%	4.39µs ± 0%	~	(p=1.000 n=1+1)
Emit-4	5.74ms ± 0%	5.52ms ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	2.12µs ± 0%	1.80µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	254ns ± 0%	242ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	42.6ns ± 0%	42.6ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	191µs ± 0%	187µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	27.9µs ± 0%	27.1µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	30.8µs ± 0%	30.4µs ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewCompilerNewVM-4	60.2µs ± 0%	62.8µs ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewVM-4	34.9µs ± 0%	34.6µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	2.51ms ± 0%	2.41ms ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	148µs ± 0%	146µs ± 0%	~	(p=1.000 n=1+1)
InterpreterImperativeFib-4	26.6µs ± 0%	26.0µs ± 0%	~	(p=1.000 n=1+1)
InterpreterNewStruct-4	81.7µs ± 0%	76.6µs ± 0%	~	(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-4	51.9µs ± 0%	52.5µs ± 0%	~	(p=1.000 n=1+1)
MethodCall/interface_method_call-4	73.7µs ± 0%	70.9µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	920ns ± 0%	894ns ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	337ns ± 0%	325ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewStruct-4	56.3µs ± 0%	55.0µs ± 0%	~	(p=1.000 n=1+1)
NewStructRaw-4	4.33µs ± 0%	4.24µs ± 0%	~	(p=1.000 n=1+1)
RecursionFib-4	1.90ms ± 0%	1.89ms ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4	806µs ± 0%	845µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	673µs ± 0%	652µs ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	3.03ms ± 0%	2.86ms ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	12.0ms ± 0%	11.3ms ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	15.9µs ± 0%	15.8µs ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	49.2µs ± 0%	47.7µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	61.0ns ± 0%	59.2ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	1.19kB ± 0%	1.16kB ± 0%	~	(p=1.000 n=1+1)
ByteArrayValueToByteSlice-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)
ByteSliceToByteArrayValue-4	963B ± 0%	967B ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4	83.5kB ± 0%	83.4kB ± 0%	~	(p=1.000 n=1+1)
CompileTime-4	17.2kB ± 0%	17.2kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	149kB ± 0%	149kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	80.2kB ± 0%	80.1kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	2.77kB ± 0%	2.74kB ± 0%	~	(p=1.000 n=1+1)
Emit-4	1.63MB ± 0%	1.70MB ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	1.05kB ± 0%	0.98kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	112B ± 0%	112B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	46.7kB ± 0%	46.7kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	8.30kB ± 0%	8.30kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	6.30kB ± 0%	6.30kB ± 0%	~	(all equal)
ImperativeFibNewCompilerNewVM-4	27.0kB ± 0%	27.0kB ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewVM-4	9.03kB ± 0%	9.03kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	1.17MB ± 0%	1.17MB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	46.3kB ± 0%	46.3kB ± 0%	~	(p=1.000 n=1+1)
InterpreterImperativeFib-4	8.29kB ± 0%	8.29kB ± 0%	~	(all equal)
InterpreterNewStruct-4	26.5kB ± 0%	26.1kB ± 0%	~	(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-4	11.4kB ± 0%	11.4kB ± 0%	~	(p=1.000 n=1+1)
MethodCall/interface_method_call-4	18.4kB ± 0%	18.4kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	1.02kB ± 0%	1.02kB ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	232B ± 0%	232B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewStruct-4	14.8kB ± 0%	14.7kB ± 0%	~	(p=1.000 n=1+1)
NewStructRaw-4	2.04kB ± 0%	1.98kB ± 0%	~	(p=1.000 n=1+1)
RecursionFib-4	342kB ± 0%	342kB ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	251kB ± 0%	252kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	175kB ± 0%	174kB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	1.82MB ± 0%	1.81MB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	7.43MB ± 0%	7.42MB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	8.19kB ± 0%	8.19kB ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	15.0kB ± 0%	15.0kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)

	allocs/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	8.00 ± 0%	8.00 ± 0%	~	(all equal)
ByteArrayValueToByteSlice-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)
ByteSliceToByteArrayValue-4	6.00 ± 0%	6.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4	581 ± 0%	581 ± 0%	~	(all equal)
CompileTime-4	212 ± 0%	212 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	2.28k ± 0%	2.28k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	1.40k ± 0%	1.40k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
Emit-4	42.0k ± 0%	42.0k ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	14.0 ± 0%	14.0 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	1.49k ± 0%	1.49k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	176 ± 0%	176 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	322 ± 0%	322 ± 0%	~	(all equal)
ImperativeFibNewCompilerNewVM-4	534 ± 0%	534 ± 0%	~	(all equal)
ImperativeFibNewVM-4	365 ± 0%	365 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	16.5k ± 0%	16.5k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	1.01k ± 0%	1.01k ± 0%	~	(all equal)
InterpreterImperativeFib-4	175 ± 0%	175 ± 0%	~	(all equal)
InterpreterNewStruct-4	418 ± 0%	418 ± 0%	~	(all equal)
MethodCall/concrete_type_method_call-4	404 ± 0%	404 ± 0%	~	(all equal)
MethodCall/interface_method_call-4	514 ± 0%	514 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	16.0 ± 0%	16.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewStruct-4	432 ± 0%	432 ± 0%	~	(all equal)
NewStructRaw-4	32.0 ± 0%	32.0 ± 0%	~	(all equal)
RecursionFib-4	19.5k ± 0%	19.5k ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	4.22k ± 0%	4.22k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	3.22k ± 0%	3.22k ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-4	36.7k ± 0%	36.7k ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	131k ± 0%	131k ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	117 ± 0%	117 ± 0%	~	(all equal)
RuntimeVMInvokeContractImperativeFib-4	489 ± 0%	489 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

Fix function conversion

768d9f9

SupunS self-assigned this Jul 10, 2026

SupunS added the Bugfix label Jul 10, 2026

SupunS marked this pull request as ready for review July 13, 2026 16:02

SupunS requested a review from turbolent as a code owner July 13, 2026 16:02

turbolent approved these changes Jul 13, 2026

View reviewed changes

SupunS merged commit 64b1ef2 into master Jul 13, 2026
16 of 17 checks passed

SupunS deleted the supun/fix-func-conversion branch July 13, 2026 17:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Compiler] Fix function conversion#4517

[Compiler] Fix function conversion#4517
SupunS merged 1 commit into
masterfrom
supun/fix-func-conversion

SupunS commented Jul 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

SupunS commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions Bot commented Jul 10, 2026

Dependency Review

Scanned Files

Uh oh!

github-actions Bot commented Jul 10, 2026

Benchstat comparison

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

SupunS commented Jul 10, 2026 •

edited

Loading