test(grok): fix PreferredOIDC test expiry rot - #104
Merged
Conversation
TestParseGrokAuth_PreferredOIDC hardcoded expires_at 2026-07-01, which became a past date and flipped IsExpired() to true, failing on line 49. Use 2099-01-01 to match the never-expires convention already used by TestDetectGrokCredentials_ValidFile in the same file.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestParseGrokAuth_PreferredOIDChardcodedexpires_at: 2026-07-01, which is now a past date -IsExpired()flips to true and the test fails (should not be expired) on any run after that date. This madeinternal/apired on clean main independent of any feature work.Fix: use
2099-01-01, matching the never-expires convention already used byTestDetectGrokCredentials_ValidFilein the same file.Verified:
go test ./internal/api/is now fully green.