Skip to content

fix(release): name the package npm refuses to stage, and check trusted publishers first - #450

Merged
vite-hub[bot] merged 1 commit into
mainfrom
t3/fix-staged-publish
Nov 17, 2026
Merged

vite-hub[bot] merged 1 commit into
mainfrom
t3/fix-staged-publish

Conversation

@onmax

@onmax onmax commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

With pnpm's trustPolicy: no-downgrade, comark-ui@0.12.2 and comark-linter@0.12.2 don't install. Drop's report skill hits it on vp dlx --package comark-linter --package comark-ui comark-lint:

[ERR_PNPM_TRUST_DOWNGRADE] High-risk trust downgrade for "comark-zoom@0.12.2" (possible package takeover)
This error happened while installing the dependencies of comark-ui@0.12.2
Earlier versions had staged publish, but this version has trusted publisher.

With a fresh store, pnpm 11.18 refuses three packages, one after another: comark-zoom, comark-annotate and comark-carousel, all at 0.12.2. Their first releases (0.1.0 to 0.2.0) were staged and approved with 2FA. #42 switched to direct npm publish on 2026-10-20, so every version since then has one rank less evidence: annotate and carousel from 0.4.1, zoom from 0.7.1. The other 51 packages were never staged, so pnpm accepts them.

#435 already moved the release back to npm stage publish, with the same command and flags uppt's publish action used for the staged versions. It merged about four hours after 0.12.2 went out, so no release has used it yet. The next one, v0.13.0 (#448), stages every package, and pnpm accepts a staged version after a staged one. Installs of comark-ui@latest work again once its packages are approved. The 0.4.1 to 0.12.2 versions stay blocked, and since there won't be a 0.12.3, projects on ^0.12 need to move to ^0.13.

One thing could still stop that release. A trusted publisher that only allows npm publish refuses npm stage publish. The publishers changed after the staged releases: comark-zoom@0.2.0 and @0.12.2 carry different oidcConfigIds. I couldn't read the current settings: the npmjs.com page needs the security key, and npm trust list needs a one-time password. This PR names the refused package and the fix in the publish job's error, instead of only failing the wave, and AGENTS.md now says to check the publishers with npm trust list before the first staged release.

test/npm-trust.test.ts passes. I also ran the publish function against a stubbed npm that answers E403: it prints the new error and xargs exits 123, so the later waves aren't staged. Only a real release can prove that staging goes through.

…d publishers first

A trusted publisher set up while releases went out directly may not allow npm stage publish, which the next release is the first to use. The publish job now names the refused package and the fix.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-17T09:27:53.997780Z
We couldn’t complete this review. Comment @codex review to try again.
8440368 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found. No P0 or P1 findings remain.

Reviewed changes Reviewed the release workflow’s staging-failure handling and the accompanying trusted-publisher guidance.

  • Package-specific diagnostics: Failed staging now identifies the package and version, suggests checking trusted-publisher permissions for E403/E404 responses, and preserves failure propagation so dependent waves do not run.
  • Publisher checks: Release instructions now call for manually inspecting existing trusted publishers before the first staged release.

Validation: All three tests in test/npm-trust.test.ts passed. Shell syntax and stubbed executions of the actual publish step also passed for successful staging, E403 failure, and already-published versions. Live npm publisher settings and OIDC staging were not exercised.

Pullfrog  | View workflow run | Using gpt-6.1-sol(xhigh) | 𝕏

@pkg-pr-new

pkg-pr-new Bot commented Nov 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark-annotate

pnpm add https://pkg.pr.new/comark-annotate@450

comark-badge

pnpm add https://pkg.pr.new/comark-badge@450

comark-bundle

pnpm add https://pkg.pr.new/comark-bundle@450

comark-cards

pnpm add https://pkg.pr.new/comark-cards@450

comark-carousel

pnpm add https://pkg.pr.new/comark-carousel@450

comark-cast

pnpm add https://pkg.pr.new/comark-cast@450

comark-charts

pnpm add https://pkg.pr.new/comark-charts@450

comark-chat

pnpm add https://pkg.pr.new/comark-chat@450

comark-chips

pnpm add https://pkg.pr.new/comark-chips@450

comark-cjk

pnpm add https://pkg.pr.new/comark-cjk@450

comark-code

pnpm add https://pkg.pr.new/comark-code@450

comark-code-notes

pnpm add https://pkg.pr.new/comark-code-notes@450

comark-colors

pnpm add https://pkg.pr.new/comark-colors@450

comark-comments

pnpm add https://pkg.pr.new/comark-comments@450

comark-critic

pnpm add https://pkg.pr.new/comark-critic@450

comark-deflist

pnpm add https://pkg.pr.new/comark-deflist@450

comark-details

pnpm add https://pkg.pr.new/comark-details@450

comark-diagrams

pnpm add https://pkg.pr.new/comark-diagrams@450

comark-diff

pnpm add https://pkg.pr.new/comark-diff@450

comark-embed

pnpm add https://pkg.pr.new/comark-embed@450

comark-fields

pnpm add https://pkg.pr.new/comark-fields@450

comark-figure

pnpm add https://pkg.pr.new/comark-figure@450

comark-file-tree

pnpm add https://pkg.pr.new/comark-file-tree@450

comark-footnotes

pnpm add https://pkg.pr.new/comark-footnotes@450

comark-git-graph

pnpm add https://pkg.pr.new/comark-git-graph@450

comark-github

pnpm add https://pkg.pr.new/comark-github@450

comark-icon

pnpm add https://pkg.pr.new/comark-icon@450

comark-include

pnpm add https://pkg.pr.new/comark-include@450

comark-keys

pnpm add https://pkg.pr.new/comark-keys@450

comark-links

pnpm add https://pkg.pr.new/comark-links@450

comark-linter

pnpm add https://pkg.pr.new/comark-linter@450

comark-magic-move

pnpm add https://pkg.pr.new/comark-magic-move@450

comark-mark

pnpm add https://pkg.pr.new/comark-mark@450

markdown-it-to-comark

pnpm add https://pkg.pr.new/markdown-it-to-comark@450

marked-to-comark

pnpm add https://pkg.pr.new/marked-to-comark@450

comark-mathml

pnpm add https://pkg.pr.new/comark-mathml@450

comark-media

pnpm add https://pkg.pr.new/comark-media@450

comark-metrics

pnpm add https://pkg.pr.new/comark-metrics@450

migrate-to-comark

pnpm add https://pkg.pr.new/migrate-to-comark@450

comark-outline

pnpm add https://pkg.pr.new/comark-outline@450

comark-properties

pnpm add https://pkg.pr.new/comark-properties@450

comark-qr

pnpm add https://pkg.pr.new/comark-qr@450

comark-quiz

pnpm add https://pkg.pr.new/comark-quiz@450

comark-reading-time

pnpm add https://pkg.pr.new/comark-reading-time@450

remark-to-comark

pnpm add https://pkg.pr.new/remark-to-comark@450

comark-sources

pnpm add https://pkg.pr.new/comark-sources@450

comark-steps

pnpm add https://pkg.pr.new/comark-steps@450

comark-table

pnpm add https://pkg.pr.new/comark-table@450

comark-tabs

pnpm add https://pkg.pr.new/comark-tabs@450

comark-tests

pnpm add https://pkg.pr.new/comark-tests@450

comark-time

pnpm add https://pkg.pr.new/comark-time@450

comark-ui

pnpm add https://pkg.pr.new/comark-ui@450

comark-xref

pnpm add https://pkg.pr.new/comark-xref@450

comark-zoom

pnpm add https://pkg.pr.new/comark-zoom@450

commit: 8440368

@vite-hub
vite-hub Bot merged commit 2d14920 into main Nov 17, 2026
6 checks passed
@vite-hub
vite-hub Bot deleted the t3/fix-staged-publish branch November 17, 2026 09:39
@vite-hub

vite-hub Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor
Session Status Started Duration
Pending Completed 2026-11-17T09:38:55.747Z 37s

Latest result

Merged 8440368 directly: required checks passed and review threads were resolved.

Final answers

Session

Merged 8440368 directly: required checks passed and review threads were resolved.

@github-actions github-actions Bot mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant