Repository navigation
feat(annotate): let readers hide marks and dim the others on hover - #454
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
comark-annotate
comark-badge
comark-bundle
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-git-graph
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
markdown-it-to-comark
marked-to-comark
comark-mathml
comark-media
comark-metrics
migrate-to-comark
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
remark-to-comark
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-time
comark-ui
comark-xref
comark-zoom
commit: |
There was a problem hiding this comment.
Important
The new Hide marks checkbox is unreachable by keyboard inside the zoomed view.
Reviewed changes Reviewed the mark-visibility controls across screenshot rendering, zoom and copy integration, documentation, and tests.
- Hide marks: Adds a script-independent checkbox for annotated screenshots, preserves its state when entering zoom, and excludes the control from copied images and thumbnails.
- Dimming: Fades inactive marks and arrows during annotation interaction while keeping captured images at rest.
- Documentation and validation: Updates screenshot and theming documentation; the workspace build, 73 annotate unit tests, and all 19 annotate browser tests passed. Additional browser testing reproduced the keyboard issue below.
gpt-6.1-sol(xhigh) | 𝕏
Latest result Pull request merged. Final answersSession Pull request merged. Session Pushed 67b7ac6 and resolved the keyboard-test finding. Bounded forward Tab navigation now accommodates native dialog focus handling while preserving Space, Close navigation, and Escape assertions. Lint, formatting, and diff checks passed. Local browser validation was blocked by sandbox localhost binding EPERM; awaiting hosted CI and automated review. Session Pushed 67b7ac6 and resolved the keyboard-test finding. Bounded forward Tab navigation now accommodates native dialog focus handling while preserving Space, Close navigation, and Escape assertions. Lint, formatting, and diff checks passed. Local browser validation was blocked by sandbox localhost binding EPERM; awaiting hosted CI and automated review. Session Pushed 67b7ac6 and resolved the keyboard-test finding. Bounded forward Tab navigation now accommodates native dialog focus handling while preserving Space, Close navigation, and Escape assertions. Lint, formatting, and diff checks passed. Local browser validation was blocked by sandbox localhost binding EPERM; awaiting hosted CI and automated review. Session Pushed 67b7ac6 and resolved the keyboard-test finding. Bounded forward Tab navigation now accommodates native dialog focus handling while preserving Space, Close navigation, and Escape assertions. Lint, formatting, and diff checks passed. Local browser validation was blocked by sandbox localhost binding EPERM; awaiting hosted CI and automated review. Session Pushed 67b7ac6 and resolved the keyboard-test finding. Bounded forward Tab navigation now accommodates native dialog focus handling while preserving Space, Close navigation, and Escape assertions. Lint, formatting, and diff checks passed. Local browser validation was blocked by sandbox localhost binding EPERM; awaiting hosted CI and automated review. Session Pushed 67b7ac6 and resolved the keyboard-test finding. Bounded forward Tab navigation now accommodates native dialog focus handling while preserving Space, Close navigation, and Escape assertions. Lint, formatting, and diff checks passed. Local browser validation was blocked by sandbox localhost binding EPERM; awaiting hosted CI and automated review. Session Pushed 67b7ac6 and resolved the keyboard-test finding. Bounded forward Tab navigation now accommodates native dialog focus handling while preserving Space, Close navigation, and Escape assertions. Lint, formatting, and diff checks passed. Local browser validation was blocked by sandbox localhost binding EPERM; awaiting hosted CI and automated review. Prepared the keyboard-test repair using bounded forward Tab navigation while preserving Space, Close navigation, and Escape assertions. Lint and diff checks passed; browser validation was blocked by sandbox port-binding EPERM. The host connection failed and commitRepair stalled, so the edit remains uncommitted and unpushed. Retry is needed to commit, push, and resolve the review thread. |
There was a problem hiding this comment.
Important
The keyboard-access fix works, but its new regression test fails because it assumes the wrong Copy location and tab order.
Reviewed changes Reviewed 38f65a0, the changes since the prior Pullfrog review.
- Expanded keyboard coverage: Included native form controls in zoom's focus trap while excluding disabled controls and elements with
tabindex="-1". - Added regression assertions: Exercised
Shift+Tab,Tab, and Space inside the zoomed screenshot; the new Copy assertion fails before reaching the toggle. - Validated the runtime fix: Passed 83 unit tests and 43 of 44 annotate/zoom browser tests; an independent browser test confirmed the checkbox is reachable and toggles correctly using the actual focus order.
gpt-6.1-sol(xhigh) | 𝕏
There was a problem hiding this comment.
✅ No new issues found. No P0 or P1 findings remain.
Reviewed changes Reviewed e1e59de, the keyboard-test correction since the previous substantive review; the intervening merge introduced no changes to the PR's own hunks.
- Corrected keyboard navigation: Removed the nonexistent stage-local Copy assertion and extra
Shift+Tab, matching the actual path from the dialog to Hide marks. - Preserved regression coverage: Retained Space toggling and reverse/forward navigation between Hide marks and Close.
- Validated the correction: All 44 annotate/zoom browser tests and the modified file's formatting/lint checks passed.
gpt-6.1-sol(xhigh) | 𝕏
There was a problem hiding this comment.
Important
The native-dialog merge makes the Hide marks keyboard regression fail again; the control itself remains keyboard-accessible.
Approach: Native <dialog> now owns focus handling, but the regression still assumes the removed manual trap's initial wrap behavior.
Reviewed changes Reviewed b7bebce, the merge resolution since the previous Pullfrog review at e1e59de.
- Removed the custom focus trap: Adopted main's native modal-dialog implementation instead of retaining the PR's expanded focusable-element selector.
- Checked annotation integration: Confirmed Hide marks remains reachable using forward Tab navigation and toggles with Space, but the retained initial
Shift+Tabassertion fails. - Validated the merge: Passed 83 unit tests, targeted formatting/lint checks, and 51 of 52 focused browser tests. GitHub CI independently reports 303 passes and the same single failure.
gpt-6.1-sol(xhigh) | 𝕏
There was a problem hiding this comment.
✅ No new issues found. No P0 or P1 findings remain.
Reviewed changes Reviewed 67b7ac6, the keyboard-test correction since the previous substantive Pullfrog review; the intervening base merge did not change the PR's own hunks.
- Replaced initial wrapping assumptions: Used bounded forward Tab navigation to reach Hide marks under native dialog focus handling.
- Preserved keyboard regression coverage: Retained the focus assertion, Space toggling, reverse/forward navigation with Close, and Escape closure.
- Validated the correction: All 44 annotate/zoom browser tests and the modified file's formatting/lint checks passed.
gpt-6.1-sol(xhigh) | 𝕏

When marks crowd a screenshot, readers can't see what's under them. They had no way to move them aside, and hovering one mark didn't set it apart from the others.
This adds two things to every screenshot with marks:
label.ca-hide, and.ca-frame:has(>.ca-hide>:checked)hides the marks and arrows, so it works without the script. The zoomed view keeps the reader's choice. Copy still draws the marks, since its button says "Copy with marks". Sliders andannotateHtml()(charts) get no toggle, the same as Copy.--ca-dimnext to the existing--ca-on. A copy paints them at rest.The screenshot docs and the class and token lists name the toggle.
Validation: two new cases in
e2e/annotate.e2e.ts(hide, including zoom, Copy, and the keyboard; dim on note and mark hover) fail onmainand pass here, with the other 17 annotate e2e cases. The annotate unit tests pass (73), and so dovp check,tsrs, the docs typecheck, and Vite Doctor. Inpnpm test, onlyremark-to-comark's "refuses to migrate with no git repository" times out, the same on the U106 branch, which doesn't touch it. I checked the hover, dim, and hidden states in screenshots from Chromium.🤖 Generated with Claude Code