Repository navigation
fix(docs): pad the playground preview 1rem instead of 2rem - #459
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound — reducing padding in the shared preview document fixes the playground spacing without changing the gallery's explicit zero-padding override.
Reviewed changes Reviewed both changed files and their preview consumers; no P0 or P1 findings.
- Preview spacing: changes the body padding from
2remto1rem, retaining a gutter for annotations that extend beyond screenshot edges. - Regression coverage: adds a computed-padding assertion; all six tests in
e2e/play-preview.e2e.tspassed locally. The full docs build andpnpm readywere not run during this review.
gpt-6.1-sol(xhigh) | 𝕏
comark-annotate
comark-badge
comark-bundle
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-git-graph
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
markdown-it-to-comark
marked-to-comark
comark-mathml
comark-media
comark-metrics
migrate-to-comark
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
remark-to-comark
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-time
comark-ui
comark-xref
comark-zoom
commit: |
Latest result Pull request merged. Final answersSession Pull request merged. |

The playground's preview set
body{padding:2rem}, so every preset sat 32px inside the frame and the preview pane lost space it didn't need.This PR drops it to 1rem. Zero is too tight: on annotate's preset the numbered badge and the hand-drawn mark sit past the screenshot's edge, and the frame cut them off at 0. At 1rem they stay whole. Gallery cells keep their own
padding:0.Validation:
e2e/play-preview.e2e.tschecks the preview body's padding. It fails onmain(32px) and passes here, along with the other 5 tests in that file./play, I set the preview body's padding to 0 and to 1rem in the frame and compared screenshots of the annotate preset: 0 cut the first badge, 1rem didn't.I didn't run
pnpm readyor build the docs.🤖 Generated with Claude Code