Skip to content

fix(docs): pad the playground preview 1rem instead of 2rem - #459

Merged
vite-hub[bot] merged 1 commit into
mainfrom
fix/playground-preview-padding
Nov 17, 2026
Merged

vite-hub[bot] merged 1 commit into
mainfrom
fix/playground-preview-padding

Conversation

@onmax

@onmax onmax commented Nov 17, 2026

Copy link
Copy Markdown
Owner

The playground's preview set body{padding:2rem}, so every preset sat 32px inside the frame and the preview pane lost space it didn't need.

This PR drops it to 1rem. Zero is too tight: on annotate's preset the numbered badge and the hand-drawn mark sit past the screenshot's edge, and the frame cut them off at 0. At 1rem they stay whole. Gallery cells keep their own padding:0.

Validation:

  • New test in e2e/play-preview.e2e.ts checks the preview body's padding. It fails on main (32px) and passes here, along with the other 5 tests in that file.
  • On the live /play, I set the preview body's padding to 0 and to 1rem in the frame and compared screenshots of the annotate preset: 0 cut the first badge, 1rem didn't.

I didn't run pnpm ready or build the docs.

🤖 Generated with Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-17T20:42:03.538462Z
We couldn’t complete this review. Comment @codex review to try again.
13d3062 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — reducing padding in the shared preview document fixes the playground spacing without changing the gallery's explicit zero-padding override.

Reviewed changes Reviewed both changed files and their preview consumers; no P0 or P1 findings.

  • Preview spacing: changes the body padding from 2rem to 1rem, retaining a gutter for annotations that extend beyond screenshot edges.
  • Regression coverage: adds a computed-padding assertion; all six tests in e2e/play-preview.e2e.ts passed locally. The full docs build and pnpm ready were not run during this review.

Pullfrog  | View workflow run | Using gpt-6.1-sol(xhigh) | 𝕏

@pkg-pr-new

pkg-pr-new Bot commented Nov 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark-annotate

pnpm add https://pkg.pr.new/comark-annotate@459

comark-badge

pnpm add https://pkg.pr.new/comark-badge@459

comark-bundle

pnpm add https://pkg.pr.new/comark-bundle@459

comark-cards

pnpm add https://pkg.pr.new/comark-cards@459

comark-carousel

pnpm add https://pkg.pr.new/comark-carousel@459

comark-cast

pnpm add https://pkg.pr.new/comark-cast@459

comark-charts

pnpm add https://pkg.pr.new/comark-charts@459

comark-chat

pnpm add https://pkg.pr.new/comark-chat@459

comark-chips

pnpm add https://pkg.pr.new/comark-chips@459

comark-cjk

pnpm add https://pkg.pr.new/comark-cjk@459

comark-code

pnpm add https://pkg.pr.new/comark-code@459

comark-code-notes

pnpm add https://pkg.pr.new/comark-code-notes@459

comark-colors

pnpm add https://pkg.pr.new/comark-colors@459

comark-comments

pnpm add https://pkg.pr.new/comark-comments@459

comark-critic

pnpm add https://pkg.pr.new/comark-critic@459

comark-deflist

pnpm add https://pkg.pr.new/comark-deflist@459

comark-details

pnpm add https://pkg.pr.new/comark-details@459

comark-diagrams

pnpm add https://pkg.pr.new/comark-diagrams@459

comark-diff

pnpm add https://pkg.pr.new/comark-diff@459

comark-embed

pnpm add https://pkg.pr.new/comark-embed@459

comark-fields

pnpm add https://pkg.pr.new/comark-fields@459

comark-figure

pnpm add https://pkg.pr.new/comark-figure@459

comark-file-tree

pnpm add https://pkg.pr.new/comark-file-tree@459

comark-footnotes

pnpm add https://pkg.pr.new/comark-footnotes@459

comark-git-graph

pnpm add https://pkg.pr.new/comark-git-graph@459

comark-github

pnpm add https://pkg.pr.new/comark-github@459

comark-icon

pnpm add https://pkg.pr.new/comark-icon@459

comark-include

pnpm add https://pkg.pr.new/comark-include@459

comark-keys

pnpm add https://pkg.pr.new/comark-keys@459

comark-links

pnpm add https://pkg.pr.new/comark-links@459

comark-linter

pnpm add https://pkg.pr.new/comark-linter@459

comark-magic-move

pnpm add https://pkg.pr.new/comark-magic-move@459

comark-mark

pnpm add https://pkg.pr.new/comark-mark@459

markdown-it-to-comark

pnpm add https://pkg.pr.new/markdown-it-to-comark@459

marked-to-comark

pnpm add https://pkg.pr.new/marked-to-comark@459

comark-mathml

pnpm add https://pkg.pr.new/comark-mathml@459

comark-media

pnpm add https://pkg.pr.new/comark-media@459

comark-metrics

pnpm add https://pkg.pr.new/comark-metrics@459

migrate-to-comark

pnpm add https://pkg.pr.new/migrate-to-comark@459

comark-outline

pnpm add https://pkg.pr.new/comark-outline@459

comark-properties

pnpm add https://pkg.pr.new/comark-properties@459

comark-qr

pnpm add https://pkg.pr.new/comark-qr@459

comark-quiz

pnpm add https://pkg.pr.new/comark-quiz@459

comark-reading-time

pnpm add https://pkg.pr.new/comark-reading-time@459

remark-to-comark

pnpm add https://pkg.pr.new/remark-to-comark@459

comark-sources

pnpm add https://pkg.pr.new/comark-sources@459

comark-steps

pnpm add https://pkg.pr.new/comark-steps@459

comark-table

pnpm add https://pkg.pr.new/comark-table@459

comark-tabs

pnpm add https://pkg.pr.new/comark-tabs@459

comark-tests

pnpm add https://pkg.pr.new/comark-tests@459

comark-time

pnpm add https://pkg.pr.new/comark-time@459

comark-ui

pnpm add https://pkg.pr.new/comark-ui@459

comark-xref

pnpm add https://pkg.pr.new/comark-xref@459

comark-zoom

pnpm add https://pkg.pr.new/comark-zoom@459

commit: 13d3062

@vite-hub
vite-hub Bot merged commit a01c02d into main Nov 17, 2026
6 checks passed
@vite-hub
vite-hub Bot deleted the fix/playground-preview-padding branch November 17, 2026 20:56
@github-actions github-actions Bot mentioned this pull request Nov 17, 2026
@vite-hub

vite-hub Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor
Session Status Started Duration
Pending Completed Not started —

Latest result

Pull request merged.

Final answers

Session

Pull request merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant