Repository navigation
fix(zoom): keep the close button on a phone's screen, and zoom images in an app's own carousel #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ export const css = `@layer comark{${[ | |
| "[data-zoom]:focus-visible{outline:2px solid var(--_comark-ring);outline-offset:3px}", | ||
| // The dialog fills the window in place of the browser's centered box. Its styles keep it shown after a close, so the | ||
| // closing animation runs to its end whatever closed it. | ||
| ".cz-dialog{position:fixed;inset:0;z-index:2147483000;display:grid;grid-template-rows:auto minmax(0,1fr) auto;width:auto;height:auto;max-width:none;max-height:none;margin:0;padding:0;overflow:visible;border:0;background:none;color:var(--_comark-foreground);font:13px/1.4 var(--_comark-font);outline:none}", | ||
| ".cz-dialog{position:fixed;inset:0;z-index:2147483000;display:grid;grid-template-columns:minmax(0,1fr);grid-template-rows:auto minmax(0,1fr) auto;width:auto;height:auto;max-width:none;max-height:none;margin:0;padding:0;overflow:visible;border:0;background:none;color:var(--_comark-foreground);font:13px/1.4 var(--_comark-font);outline:none}", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1 · Class: centered overflow clips the start of a scrollable strip. On a 390px touch viewport, open item 4 of seven grouped Technical details# Keep the first thumbnail reachable
## Affected sites
- `packages/zoom/src/styles.ts:17` — the explicit grid column now bounds the footer to the viewport.
- `packages/zoom/src/styles.ts:60` — `.cz-strip` still centers overflowing flex items. At `scrollLeft === 0`, the first thumbnail spans x=-165px to -69px at a 390px viewport.
## Required outcome
- A reader can scroll to and tap the first and last thumbnails in a group wider than the dialog, while short strips remain centered. |
||
| // .cz-backdrop is the backdrop, so it fades with the rest of the view. | ||
| ".cz-dialog::backdrop{background:none}", | ||
| ".cz-backdrop{position:absolute;inset:0;background:var(--cz-backdrop,color-mix(in srgb,var(--_comark-background) var(--cz-backdrop-opacity,96%),transparent))}", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 · Class: long captions shrink the close button’s hit area. At 390px the caption in this test shrinks
.cz-closeto about 25px wide instead of 36px; longer alt text can reduce it below 24px, even though the right-edge assertion still passes. Keep.cz-closefrom shrinking in the header flex row and check its width as well as its position.Technical details