Repository navigation
fix(tinyini): export TokenTypes as a type too, as @one-ini/wasm's enum is - #30
Conversation
Latest result Pull request merged. Final answersSession Pull request merged. Session Waiting for GitHub merge request abda72dc-5051-4765-9c83-05c6ad2abcb4. Ready; no actionable findings in the supplied reviews or four-file diff. Both subpaths export the new type. Six Node runtime checks and git diff --check passed; hosted lint, typecheck, build, and tests are green. Local dependencies were unavailable because host installation rejected an unsupported dependency source protocol. Working tree is clean; no repair commit or push was needed. Session Ready; no actionable findings or repair needed. The type fixture reproduced TS2749 against base source and passed on HEAD for both entry points. Package typecheck and lint passed; focused one-ini tests passed 5 tests with 1 skipped. Host installation rejected a dependency protocol; pnpm fetched dependencies, although prepare hooks encountered read-only Git configuration. The working tree is clean; no commit or push was needed. Ready; no actionable findings or repair needed. The type fixture reproduced TS2749 against base source and passed on HEAD for both entry points. Package typecheck and lint passed; focused one-ini tests passed 5 tests with 1 skipped. Host installation rejected a dependency protocol; pnpm fetched dependencies, although prepare hooks encountered read-only Git configuration. The working tree is clean; no commit or push was needed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes in all four files, including the shared type export, both public subpaths, regression coverage, and documentation corrections.
- Type export: Adds the
0 | 1 | 2 | 3 | 4type alongside the existing frozenTokenTypesvalue without changing runtime behavior. Both emitted subpath declarations retain it. - Regression coverage: Checks the exact type through both entry points and the editorconfig-style cast and switch. Package typechecking, build/publint, five focused compatibility tests, and six export tests pass. Full editorconfig integration was not rerun.
- Documentation: Corrects the WASM memory-limit examples consistently across the README and compatibility page; the linked reproduction supports the revised numbers.
gpt-6.1-sol | 𝕏
commit: |

@one-ini/wasmdeclaresTokenTypesas an enum, so it is a type as well as a value.editorconfig3 uses it as one inparseBuffer:tinyini/one-inionly exported the value, so swapping the import in editorconfig-core-js failed its build withTS2749: 'TokenTypes' refers to a value, but is being used as a type here. This adds aTokenTypestype next to the frozen object, the union of its numbers, for bothtinyini/one-iniandtinyini/one-ini-v0.1.test/types/one-ini.tsfailspnpm typecheckon main and passes here. With this build of tinyini in place of@one-ini/wasm, editorconfig-core-js builds unchanged and passes all 19 mocha tests and all 202 editorconfig-core-test cases.The README and the compatibility page also get the memory numbers right. 65,504 calls before
RuntimeError: unreachablewas for a 6.4 KB file, not an 800-byte one. An 800-byte file takes about 258,000. Measured on 0.2.1 and 0.2.2 with this reproduction, where call 65,506 is the first to throw.