Skip to content

test(tinyaml): confirm a slope over 1.8 at 4x on 16x before failing - #31

Merged
onmax merged 1 commit into
mainfrom
fix/ci-scaling-flake
Nov 7, 2026
Merged

onmax merged 1 commit into
mainfrom
fix/ci-scaling-flake

Conversation

@onmax

@onmax onmax commented Nov 7, 2026

Copy link
Copy Markdown
Owner

The last main run failed on Node 22: reading empty documents > takes linear time in tinyaml/js-yaml measured a slope of 1.87 (run). That reader is linear. Locally it comes out at 1.04 to 1.35 on Node 22 and 24, and at 0.95 to 1.27 on one core shared with a busy loop. The same shape failed earlier for js-yaml-v5, std and yamljs too.

slope() reads 4 times the input on the way and stops when the slope there is over 1.8. That gate decided on its own, and at 4x the base run is short, so a pause or the 0.1 ms CPU clock moves it a lot.

Now a slope over 1.8 at 4x reads 16 times the input once more, and that slope decides. A linear reader passes there. A quadratic one still fails without the three retry rounds: a toy quadratic reader fails at 2.10. The usual path is unchanged when 4x stays under 1.8.

I couldn't reproduce the 1.87 locally, so this is checked against the CI log and local runs, not the failing runner. Node 24.21.0 and 22, Linux.

A linear reader came out at 1.87 at 4 times the input on CI (Node 22, reading empty documents with tinyaml/js-yaml), and the early exit failed it there. Now a slope over 1.8 at 4x reads 16x once more and that slope decides, so a quadratic reader still fails soon.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-07T10:35:29.993319Z
We couldn’t complete this review. Comment @codex review to try again.
34d200d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — Reviewed the scaling-test helper change in packages/tinyaml/test/fixtures.ts and its callers.

  • Confirm before failing — A 4x slope above 1.8 now triggers a 16x measurement, whose slope determines the result instead of the intermediate measurement.
  • Preserve the normal path — The existing 16x retry path, sampling budgets, LINEAR threshold, and stack-trace restoration remain unchanged; comments document the CI false positive.

Validation: All 360 tests across fixtures.test.ts, scaling.test.ts, root.test.ts, and linter.test.ts passed. A deterministic CPU-clock probe also confirmed that a noisy 4x slope of 1.87 resolves to 1 for linear 16x work, while quadratic work still returns 2.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@pkg-pr-new

pkg-pr-new Bot commented Nov 7, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/tinyaml@31
pnpm add https://pkg.pr.new/tinyini@31
pnpm add https://pkg.pr.new/tinyjson5@31
pnpm add https://pkg.pr.new/tinyswap@31

commit: 34d200d

@onmax
onmax merged commit ff5b543 into main Nov 7, 2026
10 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant