Skip to content

Add in failsafe for div rounding errors #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cgdusek wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add in failsafe for div rounding errors #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/mapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,11 +443,14 @@ function subOrder(id: string, amount: BigInt, base: string, quote: string, direc
bin.save()
} else {
increment.orders = orders
increment.amount = increment.amount.minus(amount)
if (increment.amount.lt(BigInt.zero())) {
// TODO: figure out why this happens
// throw new Error("increment negative: " + incrementId + " amount: " + increment.amount.toString())

// There may arise situations where div rounding error in inverseAmount calcs causes amount to be greater than increment amount
// In this case set increment.amount to zero versus negative and save
if (increment.amount.lt(amount)) {
increment.amount = BigInt.zero()
increment.save()
} else {
increment.amount = increment.amount.minus(amount)
increment.save()
}
}
Expand Down