Skip to content

Fix publish pipeline to obey tagging and versioning conventions #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andybavier merged 2 commits into from
Jan 23, 2026
+8 −6
Merged

Fix publish pipeline to obey tagging and versioning conventions #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4428e6
Prefix 'v' to tags using add_v flag
andybavier Jan 23, 2026
dd9b70b
Remove obsolete parameter from update-version
andybavier Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,16 @@ permissions:
contents: read

jobs:
# CAUTION: Other actions depend on this name "tag-github"
# Tag GitHub Release
# The convention is to prefix the version with a 'v', e.g., v1.2.3
tag-github:
uses: onosproject/.github/.github/workflows/tag-github.yml@main
with:
add_v: true
secrets: inherit

# Build and Release Docker Image
# The convention is to use the same tag for the Docker image as the GitHub Release
release-image:
needs: tag-github
if: needs.tag-github.outputs.changed == 'true'
Expand All @@ -30,15 +35,12 @@ jobs:
attestations: write
uses: onosproject/.github/.github/workflows/release-image.yml@main
with:
# Prefix the version with 'v' to follow tagging conventions
docker_tag: v${{ needs.tag-github.outputs.version }}
docker_tag: ${{ needs.tag-github.outputs.version }}
secrets: inherit

# Bump Version
update-version:
needs: tag-github
if: needs.tag-github.outputs.changed == 'true'
uses: onosproject/.github/.github/workflows/bump-version.yml@main
secrets: inherit
with:
# Prefix the version with 'v' to follow tagging conventions
version: v${{ needs.tag-github.outputs.version }}
Loading