Address issue with traffic class expected by the webui - #188
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with traffic class data expected by the webui by adding missing TrafficClass fields to application filtering rules and updating the project version. Additionally, it includes a minor Dockerfile improvement.
- Added
TrafficClassfield with default values (ARP: 6, QCI: 9) to all application filtering rules - Incremented version from 0.4.7-dev to 0.4.8-dev
- Fixed CIDR notation for private network ranges in ALLOW-PUBLIC case
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/synchronizer/synchronize-slice.go | Added TrafficClass field to appFilterRule structs and corrected CIDR notations |
| VERSION | Version bump from 0.4.7-dev to 0.4.8-dev |
| Dockerfile | Changed FROM clause to use uppercase AS keyword |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
gab-arrobo
force-pushed
the
address-traffic-class-nil-pointer
branch
from
August 19, 2025 21:57
9eb17d9 to
89268e2
Compare
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
gab-arrobo
force-pushed
the
address-traffic-class-nil-pointer
branch
from
August 19, 2025 22:33
527c911 to
4336ef2
Compare
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
gab-arrobo
force-pushed
the
address-traffic-class-nil-pointer
branch
from
August 19, 2025 22:41
4336ef2 to
23d1c5b
Compare
SeanCondon
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.