Repository navigation
Verify saved diagrams across reload and canvas-lock timing - #6
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ooiyeefei
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser tests raced asynchronous editor events in two places: a successful Mermaid save's brief status was replaced by its own live-reload notice, and a reply appeared through SSE before the reply request released the locked canvas. Both could report a failed save while the backend behaved correctly.
Keep both orderings as deterministic regressions using actual requests and original responses. Check HTTP status, exact native geometry, embedded scene/SVG/revision, preservation of earlier diagrams, accepted UI selection and clean state. Wait for the real toolbar/canvas to unlock before raw mouse/keyboard gestures, select the exact shape ID, and verify the native export deleted only that target before saving. Retain source/network diagnostics as CI artifacts. No product or package files change.
Validation: independently reviewed real-transport reproductions; focused browser UAT 9/9; full npm suite 67 feature checks + 3 encryption + 10 token checks pass. Node 20/22 CI is the final merge gate. The published 1.17.0 npm archive remains byte-identical to the already reviewed package.