Feature: Add support for stripping XML comments and declarations#41
Open
GunwooYun wants to merge 1 commit intoooxi:masterfrom
Open
Feature: Add support for stripping XML comments and declarations#41GunwooYun wants to merge 1 commit intoooxi:masterfrom
GunwooYun wants to merge 1 commit intoooxi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a pre-processing step in
xml_parse_documentto strip XML comments (<!-- ... -->) and XML declarations (<? ... ?>) from the input buffer before parsing.Prior to this change, the parser would likely choke on comments or declarations as it expects a strictly structured validation-ready XML or a specific subset. This change allows the parser to handle more standard XML files that include comments or headers.
Implementation Details
xml_parse_documentinsrc/xml.c.document_lengthto reflect the new, shorter content length.Testing
I have created a test suite in
app/including a custom test runnerapp/test_runner.cand several test cases:Basic Comments:
Multiline Comments:
XML Declarations:
Nested Comments:
Consecutive Comments:
All the above tests pass successfully.
Known Limitations
The current implementation is a naive approach. It blindly searches for
<!--and-->markers without context.<node attr="<!--">), it will be incorrectly identified as a comment start, corrupting the XML.!--or cause malformed output, as it doesn't strictly validate comment syntax.I have added a warning comment in the code highlighting these limitations. For the intended lightweight use case of this library, this trade-off was chosen for simplicity and performance (O(n) single pass).