Get rid of disallow unknown fields in generated go models - #32
Merged
Conversation
shrinjay-opal
force-pushed
the
shrinjay/opal-13633-get-rid-of-disallowunknownfileds-in-generated-go-models
branch
2 times, most recently
from
September 18, 2025 22:15
6ff5d26 to
bb43be6
Compare
shrinjay-opal
force-pushed
the
shrinjay/opal-13633-get-rid-of-disallowunknownfileds-in-generated-go-models
branch
from
September 18, 2025 22:19
bb43be6 to
9c4d8b2
Compare
andrewsy-opal
approved these changes
Sep 18, 2025
andrewsy-opal
left a comment
andrewsy-opal
left a comment
Contributor
There was a problem hiding this comment.
approved but nit: for big PRs with very little non autogen code, u should flag in the description what's not autogen
shrinjay-opal
merged commit Sep 18, 2025
4dd4478
into
shrinjay/opal-13632-clean-unused-files-in-go-sdk
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reconfigures the OpenAPI generator to not disallow unknown fields. What this does do - is add an
AdditionalPropertiesstruct to each model - which contains the fields returned by the API that do not belong in the OpenAPI type. This is actually something that people rely on for SubEvents - the fields go into AdditionalProperties.You can see how this flag works in this github issue and the docs