ixml parser: attribute values may be empty or contain any character - #1222
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute regex whitelists the characters a value may contain, so parsing stops with ASSERTION_FAILED on values Excel writes into xlsx files:
<x15ac:absPath url="C:\Users\me\"/>in workbook.xml (backslash)<a:ea typeface=""/>in theme1.xml (empty value)é,şorқ(JS\wis ASCII only)Fix: a value is anything up to the closing quote,
[^"]*.Testcase included, fails on current main with ASSERTION_FAILED in
if_ixml_parser~parse. Full test suite passes.🤖 Generated with Claude Code