Skip to content

ixml parser: attribute values may be empty or contain any character - #1222

Merged
larshp merged 1 commit into
open-abap:mainfrom
kenzhemax:ixml/attribute-values
Sep 15, 2026
Merged

larshp merged 1 commit into
open-abap:mainfrom
kenzhemax:ixml/attribute-values

Conversation

@kenzhemax

Copy link
Copy Markdown
Contributor

The attribute regex whitelists the characters a value may contain, so parsing stops with ASSERTION_FAILED on values Excel writes into xlsx files:

  • <x15ac:absPath url="C:\Users\me\"/> in workbook.xml (backslash)
  • <a:ea typeface=""/> in theme1.xml (empty value)
  • a sheet name with non-English letters such as é, ş or қ (JS \w is ASCII only)

Fix: a value is anything up to the closing quote, [^"]*.

Testcase included, fails on current main with ASSERTION_FAILED in if_ixml_parser~parse. Full test suite passes.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@larshp
larshp merged commit fc1d343 into open-abap:main Sep 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants